From owner-svn-src-projects@FreeBSD.ORG Mon Jun 18 13:40:50 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C087E1065676; Mon, 18 Jun 2012 13:40:50 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id D7EA28FC18; Mon, 18 Jun 2012 13:40:49 +0000 (UTC) Received: by lbon10 with SMTP id n10so5296978lbo.13 for ; Mon, 18 Jun 2012 06:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=WZZhNcBrB2UnBzkkNt0zzSI0SpA58Met+iYh7jeSktQ=; b=Lgs5yXeb6EytlgYliblfUk3cE9qd71NI9LOgUPvMUTbjFNZkOHhgqHTNH1nEKlAYQB tj7XpIa941A5wCyN8eZ/THy0ZCkCt0XpJUznBx795tr3Zzd7QIIpKpQvdf9tkLbYpb3I cy8DBF555RLEas6RM2Jcw3AoRDZn3wAf2Ao13DCW7xf6WvR6/N+jbKQTf44mR44gxa8H 5LTrVVD0X5PLlFlUl4ewS/Cnna0UyMULawXQ8GhnojZPWNK9VOtPpJYhN4DiOSBhAEc5 sy6/xgIUISRDABeRI/1YI9+nb3Wcon/i/NssyiIHHiBltYlU+MmI3QkL7fObWmImeBs2 ucPA== MIME-Version: 1.0 Received: by 10.152.46.6 with SMTP id r6mr14712453lam.7.1340026848835; Mon, 18 Jun 2012 06:40:48 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.27.65 with HTTP; Mon, 18 Jun 2012 06:40:48 -0700 (PDT) In-Reply-To: <201206172045.q5HKjj92031635@svn.freebsd.org> References: <201206172045.q5HKjj92031635@svn.freebsd.org> Date: Mon, 18 Jun 2012 14:40:48 +0100 X-Google-Sender-Auth: 9mKvofwYcpUt8cxdIgnmYnXlRx8 Message-ID: From: Attilio Rao To: Davide Italiano Content-Type: text/plain; charset=UTF-8 Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r237202 - in projects/calloutng/sys: kern sys X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2012 13:40:50 -0000 2012/6/17, Davide Italiano : > Author: davide > Date: Sun Jun 17 20:45:45 2012 > New Revision: 237202 > URL: http://svn.freebsd.org/changeset/base/237202 > > Log: > - Extend the condvar(9) KPI introducing a new cv_timedwait_bt_sig() > function so that we can specify timeout precision in terms of struct > bintime. > > - Now seltdwait() takes three argument rather than two so that their > consumers can specify if the timeout should be passed as ticks or > bintime. > > - Refactor the kern_select() and the sys_poll() code so that these two > services may rely on cv_timedwait_bt_sig() rather than on the previous > less > precise cv_timedwait_sig(). > > - Rethink the sleepqueue(9) KPI in order to make an attempt of avoiding > both code duplication and breakages. Your mileage WILL vary, feel free to > comment. I would still prefer the unified KPI, but at least the committed code avoids code-duplication, I appreciate your effort here, thanks. Why you don't do the same thing for callout_ KPI? Attilio -- Peace can only be achieved by understanding - A. Einstein