From nobody Tue Jul 7 11:30:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gvfCr06Hkz6dRC1 for ; Tue, 07 Jul 2026 11:30:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gvfCk3whFz3M5F for ; Tue, 07 Jul 2026 11:30:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783423810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t6sWw2VIs1OWaWQSS14SRydd7i0rKe6aQvQJTgiQ6F8=; b=v2Ho7U3SmsN7MAdcSIF9QBIFVLux2U0hFtrrO3No1i+i2VAcmhPzHNuI/M8hGsBzDm2P2k Q2w5jHgXbDkv3U7JyxsmgrPKA9ECZDY4oc3GWRhU7C7VV25kzD6ACwXVw5X/X1YVN2YMH/ r4dmDXjSP7ZgEmOBTBk72qNBn/80aKKI7k78pQZR6BYUqRuYhdcUXtMptrUKWGvfrK2llK nnAzePG9CrTDG7L60F3YGl+NE+1Ar2CaPMnBkpm+PF4acoN4kNmgpHEgnIeeCmWgJRceWV N+O72egMbVrBz7yxa+Or9kuzFRgaoM8BEVnyBQfTNA/H5CnhLbyvqw5NeDv3ow== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783423810; a=rsa-sha256; cv=none; b=E0ZLvUOu7aGdXuLE4s7DRvrWyf2vRR139sxLcseOhxIB16VhOWOuWc8FdUGwzqaWb+lall m9BAB+1RFspkVs7gRhxLhssrKSXwnBNrId7I7nqdQhp3TYDfEu+B5v5IbwjmwSl5WyFKXw yfqGRpxS9upiyau7BRP3C/6QAPHptuXbW+O12or0hSzGbB/+rqjN+lHitLAjdmVoYAPftU CW8ZcwV0nRp8vshUqjza/iSHHmFyByWkr+cTVRbWkIA3zjvPbdiCN9MR0YktVA8bAjgDLd S02livlk0vkGNx5eLtRPkhGT0zgDqm3s9nleU3ZMsBQqvwuu4xwQA1WJAygT/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783423810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t6sWw2VIs1OWaWQSS14SRydd7i0rKe6aQvQJTgiQ6F8=; b=fxNDvpwLqu0isRrSpl8syk+Q/J/5hVmz4PmnlzBnnIVufMbm19vpyR5IBsu/LVZDxophFe kolT26qwR8fuOgneegrH3Tk79Sk8hpSJjYBHtbCK804o0lf6HWXCrrWi2FxoYDL8ds/g7P C+X9pjh9pTE4dLjKQ8D40HiaIvNJtNESW3H4soQYRLwB6C5qkVvqYPPhsnUA+DBj2Z5hSr FNSbpy5aKCCWZIJcr/wBGo4QW+9jksYBydUsK7Ro0kuSisZJjFHST4Sb0a1ioy2ZxP6Eo4 7/HfugtzxjZhWMIaQU/opgCOM1TGGN3SiaVkT4J2TWbEBi02lZANG/qye/3CUg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gvfCk2jmzzYqY for ; Tue, 07 Jul 2026 11:30:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 347ec by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 07 Jul 2026 11:30:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ariel Ehrenberg From: Konstantin Belousov Subject: git: 284e06dec78f - main - mlx5: guard against a NULL CQ event handler in mlx5_cq_event() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 284e06dec78ffbbf8919dc0aa11073ecabba7176 Auto-Submitted: auto-generated Date: Tue, 07 Jul 2026 11:30:10 +0000 Message-Id: <6a4ce342.347ec.5f1501ed@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=284e06dec78ffbbf8919dc0aa11073ecabba7176 commit 284e06dec78ffbbf8919dc0aa11073ecabba7176 Author: Ariel Ehrenberg AuthorDate: 2026-06-15 08:16:17 +0000 Commit: Konstantin Belousov CommitDate: 2026-07-07 11:25:41 +0000 mlx5: guard against a NULL CQ event handler in mlx5_cq_event() DEVX and mlx5en created CQs are registered without an asynchronous event handler (mcq.event is NULL). An asynchronous CQ_ERROR event for such a CQ made mlx5_cq_event() call through a NULL pointer and panic. Reviewed by: kib Tested by: Wafa Hamzah Sponsored by: Nvidia networking MFC after: 1 month --- sys/dev/mlx5/mlx5_core/mlx5_cq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/mlx5/mlx5_core/mlx5_cq.c b/sys/dev/mlx5/mlx5_core/mlx5_cq.c index fa28ae6dece9..f1f8fc03de6c 100644 --- a/sys/dev/mlx5/mlx5_core/mlx5_cq.c +++ b/sys/dev/mlx5/mlx5_core/mlx5_cq.c @@ -113,7 +113,8 @@ void mlx5_cq_event(struct mlx5_core_dev *dev, u32 cqn, int event_type) spin_unlock(&table->writerlock); if (likely(cq != NULL)) { - cq->event(cq, event_type); + if (cq->event) + cq->event(cq, event_type); } else { mlx5_core_warn(dev, "Asynchronous event for bogus CQ 0x%x\n", cqn);