From owner-freebsd-current@FreeBSD.ORG Thu Dec 2 23:37:26 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A2B316A4CE; Thu, 2 Dec 2004 23:37:26 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 385A743D39; Thu, 2 Dec 2004 23:37:26 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id iB2NZEKt072206; Thu, 2 Dec 2004 18:35:14 -0500 (EST) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)iB2NZEd2072203; Thu, 2 Dec 2004 23:35:14 GMT (envelope-from robert@fledge.watson.org) Date: Thu, 2 Dec 2004 23:35:14 +0000 (GMT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Mark Santcroos In-Reply-To: <20041202215123.GA1512@laptop.6bone.nl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Poul-Henning Kamp cc: current@FreeBSD.org Subject: Re: VOP_* changes causes NULL ptr dereference for acl_get_file(3) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2004 23:37:26 -0000 On Thu, 2 Dec 2004, Mark Santcroos wrote: > I need at least the following patch to keep my system alive. A simple > call to acl_get_file(3) is enough to crash the machine. > > You will have to think a bit more about how you want to initialize stuff > or about better defaults for cases like ACLs. Should probably be using VOP_EOPNOTSUPP rather than VOP_EINVAL, I think. Also, it's likely that if you need a vop_getacl entry here, you probably also want a vop_setacl and a vop_checkacl entry. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research > > Mark > > ==== //depot/projects/custom/kern/vfs_default.c#35 - /home/marks/proj/perforce/projects/custom/kern/vfs_default.c ==== > @@ -95,6 +95,7 @@ > .vop_revoke = VOP_PANIC, > .vop_strategy = vop_nostrategy, > .vop_unlock = vop_stdunlock, > + .vop_getacl = VOP_EINVAL, > }; > > /* > > -- > RIPE NCC - Delft University of Technology - The FreeBSD Project > marks@ripe.net - m.a.santcroos@ewi.tudelft.nl - marks@freebsd.org > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >