From owner-freebsd-ports@FreeBSD.ORG  Sat Feb 23 09:48:35 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 5A29B1C3
 for <ports@freebsd.org>; Sat, 23 Feb 2013 09:48:35 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-ie0-x22a.google.com (mail-ie0-x22a.google.com
 [IPv6:2607:f8b0:4001:c03::22a])
 by mx1.freebsd.org (Postfix) with ESMTP id 0457D35E
 for <ports@freebsd.org>; Sat, 23 Feb 2013 09:48:34 +0000 (UTC)
Received: by mail-ie0-f170.google.com with SMTP id c11so1684223ieb.29
 for <ports@freebsd.org>; Sat, 23 Feb 2013 01:48:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=I8szdMeroo8vLgO0cFpNw/pFmngpr7tjlrXJN7ezdUY=;
 b=NspKk6nxq2d4ux4P6FETIVKbkbQBVwydoLa6SNINgrYuaX3O7NkIWaY5rVo6GRNeBG
 tBxxHeFWmLG/g/9G62UtPkYqyvJp0tNpy/TyVeyQ3keQXGaguZhwQRt4w7rRD86TiKTf
 aEWDQzxN1+T4v80CLIzz8NZfPL3QzuYlLncwkM+DYHPhU+hsUOOyRxR4Y+9NCyl39wYU
 G9RUcWJtH2iUFRIsEoB/Rd52SfxJwDvhYMkhjR3qUg0D+eAghBh4ohYCQ0MqmzTG95HD
 IdNxC0TsZA86VKW5HB8hWjCmq8LA7Ahhq4TdEeDQYnp35XmFRa3vd1FzYsPmZcbJX6Kg
 15Gw==
MIME-Version: 1.0
X-Received: by 10.50.152.132 with SMTP id uy4mr618594igb.62.1361612912813;
 Sat, 23 Feb 2013 01:48:32 -0800 (PST)
Received: by 10.64.63.12 with HTTP; Sat, 23 Feb 2013 01:48:32 -0800 (PST)
Received: by 10.64.63.12 with HTTP; Sat, 23 Feb 2013 01:48:32 -0800 (PST)
In-Reply-To: <CAF6rxgnoyNMvpa_RDZi8Rf4HpZ139KL=ZARP9tHOETbiJjU2rA@mail.gmail.com>
References: <CAF6rxgnoyNMvpa_RDZi8Rf4HpZ139KL=ZARP9tHOETbiJjU2rA@mail.gmail.com>
Date: Sat, 23 Feb 2013 09:48:32 +0000
Message-ID: <CADLo83_bb=WQyMxu1wqnVeHn6ncZ-cACTtcVXDDYAdCwUNg=QQ@mail.gmail.com>
Subject: Re: CONFIGURE_ENV and CPPFLAGS
From: Chris Rees <utisoft@gmail.com>
To: Eitan Adler <lists@eitanadler.com>, Dmitry Marakasov <amdmi3@amdmi3.ru>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: ports@freebsd.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Feb 2013 09:48:35 -0000

On 22 Feb 2013 23:46, "Eitan Adler" <lists@eitanadler.com> wrote:
>
> Can you please sanity check the following?
>
> commit 687519c34ad3423752268a0a20d079fda9cea8b2
> Author: Eitan Adler <lists@eitanadler.com>
> Date:   Fri Feb 22 18:43:30 2013 -0500
>
>     Using CONFIGURE_ENV for CPPFLAGS and
>     LDFLAGS is not needed since r282433.
>
>     PR:         docs/174827
>     Submitted by:       Dominique Goncalves <dominique.goncalves@gmail.com
>
>
> diff --git a/en_US.ISO8859-1/books/porters-handbook/book.xml
> b/en_US.ISO8859-1/books/porters-handbook/book.xml
> index ef50257..c64cdc7 100644
> --- a/en_US.ISO8859-1/books/porters-handbook/book.xml
> +++ b/en_US.ISO8859-1/books/porters-handbook/book.xml
> @@ -5726,17 +5726,13 @@ IGNORE= may not be redistributed because of
> licensing reasons. Please visit <rep
>  CPPFLAGS+=     -I${LOCALBASE}/include
>  LDFLAGS+=      -L${LOCALBASE}/lib
>
> -GNU_CONFIGURE= yes
> -CONFIGURE_ENV= CPPFLAGS="${CPPFLAGS}" \
> -               LDFLAGS="${LDFLAGS}"</programlisting>
> +GNU_CONFIGURE= yes</programlisting>
>
>         <para>Of course, the code can be more compact if there are no
>           more flags to pass to <command>configure</command>:</para>
>
>         <programlisting>USE_GETTEXT=    yes
> -GNU_CONFIGURE= yes
> -CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
> -               LDFLAGS="-L${LOCALBASE}/lib"</programlisting>
> +GNU_CONFIGURE= yes</programlisting>
>        </sect2>
>
>        <sect2>
>

I'm pretty sure this is correct, but we should do one final check with
Dmitry.

Chris