From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb 23 15:40:06 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A899B1065675
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 23 Feb 2011 15:40:06 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 626858FC15
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 23 Feb 2011 15:40:06 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p1NFe6p1023080
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 23 Feb 2011 15:40:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p1NFe6Rg023079;
	Wed, 23 Feb 2011 15:40:06 GMT (envelope-from gnats)
Resent-Date: Wed, 23 Feb 2011 15:40:06 GMT
Resent-Message-Id: <201102231540.p1NFe6Rg023079@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	"Eduard S. Markelov" <MarkelovEduard@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D48831065697
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 23 Feb 2011 15:33:23 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id C3EBD8FC25
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 23 Feb 2011 15:33:23 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p1NFXN95075000
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 23 Feb 2011 15:33:23 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p1NFXNBi074990;
	Wed, 23 Feb 2011 15:33:23 GMT (envelope-from nobody)
Message-Id: <201102231533.p1NFXNBi074990@red.freebsd.org>
Date: Wed, 23 Feb 2011 15:33:23 GMT
From: "Eduard S. Markelov" <MarkelovEduard@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/154975: typo in source code
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Feb 2011 15:40:06 -0000


>Number:         154975
>Category:       misc
>Synopsis:       typo in source code
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 23 15:40:06 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Eduard S. Markelov
>Release:        8.1-RELEASE
>Organization:
>Environment:
FreeBSD sirius.local 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:55:53 UTC 2010     root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
Typo in macro definition.

File: /usr/include/pthread.h
Line: 170
Macro: pthread_cleanup_push(cleanup_routine, cleanup_arg)

Description:
The macro no have the close brace but end with one more open brace!

Code:

#define pthread_cleanup_push(cleanup_routine, cleanup_arg) \
 { \
 struct _pthread_cleanup_info __cleanup_info__; \
 __pthread_cleanup_push_imp(cleanup_routine, cleanup_arg, \
 &__cleanup_info__); \
 {

>How-To-Repeat:

>Fix:
change open brace to close brace:

#define pthread_cleanup_push(cleanup_routine, cleanup_arg) \
 { \
 struct _pthread_cleanup_info __cleanup_info__; \
 __pthread_cleanup_push_imp(cleanup_routine, cleanup_arg, \
 &__cleanup_info__); \
 }

>Release-Note:
>Audit-Trail:
>Unformatted: