From nobody Mon Oct 28 15:44:59 2024 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xcd5H5t3Bz5bTyh for ; Mon, 28 Oct 2024 15:45:39 +0000 (UTC) (envelope-from ccfreebsd@gmail.com) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xcd5G6kCpz42Ns; Mon, 28 Oct 2024 15:45:38 +0000 (UTC) (envelope-from ccfreebsd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of ccfreebsd@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=ccfreebsd@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-53b13eae3b3so552063e87.3; Mon, 28 Oct 2024 08:45:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730130337; x=1730735137; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gGBrt2avsk6PkaV2okwJvlLZBYROS9BZ8c5/gpaWkdc=; b=vaWh8IaPHDuvGoLeUr+Vc7idCOIRWyAu+waMXG1ozQDpOdVUXMcFmAD5uVm9idauz3 oP1EndJpPRhaylNwMkGfqFsQ/KZoVYM21rUY6YAuBGHMUHc70o8SLlxXV6qSs9eZIA5t BGCjiWEnfs5y94jhKQ5/R06QwVLpAIEmbFm7cvlbrKC68kI/QCZpOCs6PLAkaI8fWyCe 9ZrjA7Xai9tIgxTvFcYvDvBldvUSuHaL1jAaH/XJcmowEZMQc5Yd62MvbsmlcMYD+mcT OMrdHrqQtRNPvxa1Cbj0aTv25BZ+cliWNwSoujFJDivv3yKfgb9RF1edO+2TZHP3F0BM 8OVg== X-Forwarded-Encrypted: i=1; AJvYcCUeZey8oyKFGD55bDbs1rVEexGMVyT+VNSQDh200gk+eHwoFyJumr8tRQJ0eM+1ZC5RN1tzAL9t@freebsd.org, AJvYcCWr85p+fDVTDApsL1yoYQUqf2eButQCeab6FM+TNKebv+ABuZSqjjvn0dFway1AwmtAcqdELGWJ@freebsd.org, AJvYcCX19llPvD4WQGycyQqgSJDIuLnHvPwUgfuW8y8ZaEkr16MwUoqp5WHUKEyeBK0I3thK8zJtFYbJAw==@freebsd.org X-Gm-Message-State: AOJu0YysHI1uhtSQKUILizpKdn7klm7hrSB5KvIUrodHP9T856kt6sKV EJ2wNbknR8QoHVo50jOx65fEr5oUPJgiWzWcdIBC1P3PM3KTqVdOSBXwAg== X-Google-Smtp-Source: AGHT+IE9UHq56FnJcBOsOjN3fsHEzny1q6muaES06dYZ/WL7pxQsKY1UPe31qlVJNpsZf5NOzXj8MA== X-Received: by 2002:a05:6512:31d1:b0:52e:fd7c:8b9b with SMTP id 2adb3069b0e04-53b3490ea51mr1341245e87.7.1730130336419; Mon, 28 Oct 2024 08:45:36 -0700 (PDT) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com. [209.85.167.49]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53b2e1c9402sm1109768e87.205.2024.10.28.08.45.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 08:45:36 -0700 (PDT) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-53b13eae3b3so552058e87.3; Mon, 28 Oct 2024 08:45:36 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU+hG125uriDuG208v9xY72dYJE3qqhiIBIxKrTW1CQK9aPXeiDS7MkzXwfmD/WHxTvVHWrzLom@freebsd.org, AJvYcCVYidAiJYkX471CzsD49tY7RXBrz3zD9qosj0E09n6kkRvb6Xke0NAKsy/UVR7u98pLFb1jfTbmEg==@freebsd.org, AJvYcCXfslSpfY5JHYi0uJP5uuELhdPnTzy9oF5bRH+fo/afr8ncNQszTVmV1peHllt6x4Fy9EY8qjzx@freebsd.org X-Received: by 2002:a05:651c:50f:b0:2fb:5a45:f8ab with SMTP id 38308e7fff4ca-2fcbe10d243mr11727801fa.12.1730130336049; Mon, 28 Oct 2024 08:45:36 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Cheng Cui Date: Mon, 28 Oct 2024 11:44:59 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: panic: tcp_do_segment: sent too much To: "Scheffenegger, Richard" Cc: Gleb Smirnoff , "rscheff@freebsd.org" , "tuexen@freebsd.org" , "current@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000187c5406258b5c15" X-Spamd-Result: default: False [-2.82 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.93)[-0.926]; FORGED_SENDER(0.30)[cc@freebsd.org,ccfreebsd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_EQ_ADDR_SOME(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.41:from]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cc@freebsd.org,ccfreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.41:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[current@freebsd.org]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4Xcd5G6kCpz42Ns X-Spamd-Bar: -- --000000000000187c5406258b5c15 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Oct 27, 2024 at 1:14=E2=80=AFPM Scheffenegger, Richard < Richard.Scheffenegger@netapp.com> wrote: > > It's possible; > > D43355 and D43470 were quite strongly interrelated if my memory serves - > any currently only the former is committed. > > OK. I give D43470 a green light for now, based on my initial test result https://wiki.freebsd.org/chengcui/testD43470. Any bugs found shall be fixed after these two. =F0=9F=98=89 cc -----Original Message----- > From: Gleb Smirnoff > Sent: Sonntag, 27. Oktober 2024 17:39 > To: rscheff@freebsd.org; tuexen@freebsd.org > Cc: current@freebsd.org > Subject: panic: tcp_do_segment: sent too much > > EXTERNAL EMAIL - USE CAUTION when clicking links or attachments > > > > > Hi, > > I just got this panic on my desktop running latest stabweek snapshot. > > panic: tcp_do_segment: sent too much > db_trace_self_wrapper() at db_trace_self_wrapper+0x2c/frame > 0xfffffe0209deb440 > kdb_backtrace() at kdb_backtrace+0x46/frame 0xfffffe0209deb4f0 > vpanic() at vpanic+0x23d/frame 0xfffffe0209deb630 > panic() at panic+0x4e/frame 0xfffffe0209deb690 > tcp_do_segment() at tcp_do_segment+0x3a6c/frame 0xfffffe0209deb8d0 > tcp_input_with_port() at tcp_input_with_port+0x15db/frame > 0xfffffe0209deba60 > tcp_input() at tcp_input+0x27/frame 0xfffffe0209deba90 > ip_input() at ip_input+0x1131/frame 0xfffffe0209debb00 > netisr_dispatch_src() at netisr_dispatch_src+0x18c/frame 0xfffffe0209debb= 70 > netisr_dispatch() at netisr_dispatch+0x21/frame 0xfffffe0209debb90 > ether_demux() at ether_demux+0x2a5/frame 0xfffffe0209debbd0 > ether_input_internal() at ether_input_internal+0x613/frame > 0xfffffe0209debc10 > ether_nh_input() at ether_nh_input+0xb1/frame 0xfffffe0209debc30 > netisr_dispatch_src() at netisr_dispatch_src+0x18c/frame 0xfffffe0209debc= a0 > netisr_dispatch() at netisr_dispatch+0x21/frame 0xfffffe0209debcc0 > ether_input() at ether_input+0x16c/frame 0xfffffe0209debd10 > > My kernel is compiled with -O0, which alleviates debugging: > > (kgdb) frame 4 > #4 0xffffffff80ea6c3c in tcp_do_segment (tp=3D0xfffff814a6f96000, > m=3D0xfffff8044d546a00, th=3D0xfffff8044d546a82, drop_hdrlen=3D64, tlen= =3D0, > iptos=3D72 'H') at /usr/src/FreeBSD/sys/netinet/tcp_input.c:2812 > 2812 > KASSERT((tp->t_dupacks =3D=3D 2 && > (kgdb) p tp->t_dupacks > $1 =3D 1 > (kgdb) p tp->snd_limited > $2 =3D 0 '\000' > (kgdb) p/x tp->t_flags > $4 =3D 0x110003e4 > (kgdb) p/x tp->t_flags & 0x00000010 # TF_SENTFIN > $5 =3D 0x0 > (kgdb) p tp->t_flags & 1 # TF_ACKNOW > $15 =3D 0 > (kgdb) p sent > $6 =3D 1507 > (kgdb) p maxseg > $7 =3D 1400 > (kgdb) p oldcwnd > $8 =3D 1400 > (kgdb) p oldsndmax > $9 =3D 2473784830 > (kgdb) p tp->snd_max > $10 =3D 2473786337 > (kgdb) p 2473786337 - 2473784830 > $11 =3D 1507 > (kgdb) p tp->snd_cwnd > $12 =3D 2800 > (kgdb) p avail > $13 =3D 2018 > (kgdb) p tp->snd_nxt - tp->snd_una > $16 =3D 2018 > (kgdb) p so->so_snd.sb_acc > $17 =3D 2018 > (kgdb) p *tp->snd_holes.tqh_first > $22 =3D {start =3D 2473784319, end =3D 2473784358, rxmit =3D 2473784319, = scblink =3D > {tqe_next =3D 0x0, tqe_prev =3D 0xfffff814a6f96350}} > > Apparently tcp_output() has sent more than one segment. I don't know if > this old assertion is correct, but looks like it started to trigger. > > Could this be related to 440f4ba18e3a? > > -- > Gleb Smirnoff > --=20 Best Regards, Cheng Cui --000000000000187c5406258b5c15 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On= Sun, Oct 27, 2024 at 1:14=E2=80=AFPM Scheffenegger, Richard <Richard.Scheffe= negger@netapp.com> wrote:

It's possible;

D43355 and D43470 were quite strongly interrelated if my memory serves - an= y currently only the former is committed.

OK. I give D4= 3470 a green light for now, based on my initial test result https://wiki.fr= eebsd.org/chengcui/testD43470.
Any= bugs found shall be fixed after these two.=C2=A0=F0=9F=98=89
cc=C2=A0

-----Original Message-----
From: Gleb Smirnoff <glebius@freebsd.org>
Sent: Sonntag, 27. Oktober 2024 17:39
To: rscheff@freebs= d.org; tuexen@f= reebsd.org
Cc: current@freebs= d.org
Subject: panic: tcp_do_segment: sent too much

EXTERNAL EMAIL - USE CAUTION when clicking links or attachments




=C2=A0 Hi,

I just got this panic on my desktop running latest stabweek snapshot.

panic: tcp_do_segment: sent too much
db_trace_self_wrapper() at db_trace_self_wrapper+0x2c/frame 0xfffffe0209deb= 440
kdb_backtrace() at kdb_backtrace+0x46/frame 0xfffffe0209deb4f0
vpanic() at vpanic+0x23d/frame 0xfffffe0209deb630
panic() at panic+0x4e/frame 0xfffffe0209deb690
tcp_do_segment() at tcp_do_segment+0x3a6c/frame 0xfffffe0209deb8d0
tcp_input_with_port() at tcp_input_with_port+0x15db/frame 0xfffffe0209deba6= 0
tcp_input() at tcp_input+0x27/frame 0xfffffe0209deba90
ip_input() at ip_input+0x1131/frame 0xfffffe0209debb00
netisr_dispatch_src() at netisr_dispatch_src+0x18c/frame 0xfffffe0209debb70=
netisr_dispatch() at netisr_dispatch+0x21/frame 0xfffffe0209debb90
ether_demux() at ether_demux+0x2a5/frame 0xfffffe0209debbd0
ether_input_internal() at ether_input_internal+0x613/frame 0xfffffe0209debc= 10
ether_nh_input() at ether_nh_input+0xb1/frame 0xfffffe0209debc30
netisr_dispatch_src() at netisr_dispatch_src+0x18c/frame 0xfffffe0209debca0=
netisr_dispatch() at netisr_dispatch+0x21/frame 0xfffffe0209debcc0
ether_input() at ether_input+0x16c/frame 0xfffffe0209debd10

My kernel is compiled with -O0, which alleviates debugging:

(kgdb) frame 4
#4=C2=A0 0xffffffff80ea6c3c in tcp_do_segment (tp=3D0xfffff814a6f96000, m= =3D0xfffff8044d546a00, th=3D0xfffff8044d546a82, drop_hdrlen=3D64, tlen=3D0,=
=C2=A0 =C2=A0 iptos=3D72 'H') at /usr/src/FreeBSD/sys/netinet/tcp_i= nput.c:2812
2812=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 KASSERT((tp->t_dupacks =3D=3D 2 &= amp;&
(kgdb) p tp->t_dupacks
$1 =3D 1
(kgdb) p tp->snd_limited
$2 =3D 0 '\000'
(kgdb) p/x tp->t_flags
$4 =3D 0x110003e4
(kgdb) p/x tp->t_flags & 0x00000010=C2=A0 =C2=A0 =C2=A0# TF_SENTFIN<= br> $5 =3D 0x0
(kgdb) p tp->t_flags & 1=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 # TF_ACKNOW
$15 =3D 0
(kgdb) p sent
$6 =3D 1507
(kgdb) p maxseg
$7 =3D 1400
(kgdb) p oldcwnd
$8 =3D 1400
(kgdb) p oldsndmax
$9 =3D 2473784830
(kgdb) p tp->snd_max
$10 =3D 2473786337
(kgdb) p 2473786337 - 2473784830
$11 =3D 1507
(kgdb) p tp->snd_cwnd
$12 =3D 2800
(kgdb) p avail
$13 =3D 2018
(kgdb) p tp->snd_nxt - tp->snd_una
$16 =3D 2018
(kgdb) p so->so_snd.sb_acc
$17 =3D 2018
(kgdb) p *tp->snd_holes.tqh_first
$22 =3D {start =3D 2473784319, end =3D 2473784358, rxmit =3D 2473784319, sc= blink =3D {tqe_next =3D 0x0, tqe_prev =3D 0xfffff814a6f96350}}

Apparently tcp_output() has sent more than one segment. I don't know if= this old assertion is correct, but looks like it started to trigger.

Could this be related to 440f4ba18e3a?

--
Gleb Smirnoff


--
Best Regards,
Cheng Cui
--000000000000187c5406258b5c15--