From owner-svn-src-all@FreeBSD.ORG Thu Mar 17 19:19:40 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD855106564A; Thu, 17 Mar 2011 19:19:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 57E438FC12; Thu, 17 Mar 2011 19:19:40 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id p2HJB06h025295; Thu, 17 Mar 2011 13:11:03 -0600 (MDT) (envelope-from imp@bsdimp.com) Message-ID: <4D825CC2.1020305@bsdimp.com> Date: Thu, 17 Mar 2011 13:10:58 -0600 From: Warner Losh User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101211 Thunderbird/3.1.7 MIME-Version: 1.0 To: Jilles Tjoelker References: <201103122113.p2CLD8LO030205@svn.freebsd.org> <20110312230830.GA269@stack.nl> In-Reply-To: <20110312230830.GA269@stack.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Doug Barton , src-committers@FreeBSD.org Subject: Re: svn commit: r219578 - head/etc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2011 19:19:40 -0000 On 03/12/2011 16:08, Jilles Tjoelker wrote: > On Sat, Mar 12, 2011 at 09:13:08PM +0000, Doug Barton wrote: >> Author: dougb >> Date: Sat Mar 12 21:13:08 2011 >> New Revision: 219578 >> URL: http://svn.freebsd.org/changeset/base/219578 >> Log: >> Use the allexport option in load_rc_config() in order to avoid having >> to repeatedly read the conf files. Depending on what is enabled the >> files are being read anywhere from 15, 30, or more times currently. >> By loading the values in the environment this is reduced to 1, with >> perhaps a couple more, again depending on what is enabled. > I wonder if it is a good idea to pollute the environment of many daemons > with this. Although sshd and cron clean it up, there is at least one > daemon that passes the environment on. One of those is devd. While that > saves four /etc/rc.conf reads on my minimalistic 9-current VM, it > implies that devd must be restarted to pick up changes to /etc/rc.conf. > That seems a POLA violation. devd shouldn't be passing this to its children. imho, devd should be fixed to be more robust. Warner