From owner-freebsd-stable@FreeBSD.ORG Sun Jul 2 22:54:17 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB9C916A52D; Sun, 2 Jul 2006 22:54:17 +0000 (UTC) (envelope-from tbyte@otel.net) Received: from mail.otel.net (gw3.OTEL.net [212.36.8.151]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C0DA43E87; Sun, 2 Jul 2006 22:22:15 +0000 (GMT) (envelope-from tbyte@otel.net) Received: from warhead.otel.net ([212.36.8.210]) by mail.otel.net with esmtp (Exim 4.62 (FreeBSD)) (envelope-from ) id 1FxAKT-0006AS-1N; Mon, 03 Jul 2006 01:22:13 +0300 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-send-pr-version: gtk-send-pr 0.4.7 X-GNATS-Notify: Date: Mon, 3 Jul 2006 01:22:12 +0300 From: "Iasen Kostoff" Message-Id: <1151878932.16831@WarHeaD.OTEL.net> To: "FreeBSD gnats submit" Cc: freebsd-stable@freebsd.org Subject: Bug in ata (ata-all.c) driver X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jul 2006 22:54:18 -0000 >Submitter-Id: stable-users >Originator: Iasen Kostoff >Organization: OTEL.net >Confidential: no >Synopsis: Bug in ata (ata-all.c) driver >Severity: serious >Priority: medium >Category: kern >Class: sw-bug >Release: FreeBSD 6.1-STABLE i386 >Environment: System: FreeBSD 6.1-STABLE #2: Sat Jul 1 13:01:14 EEST 2006 root@WarHeaD.OTEL.net:/usr/src6/sys/i386/compile/WARHEAD >Description: I found a little bug (probably) in sys/dev/ata-all.c which somehow corrupts device parameters structure. When I first did "atacontrol list" device info about ad0 looked like this: Master: ad0 ATA/ATAPI revision 7 after I ran "atacontrol cap ad0" it printed somewhat messy output like having enabled SMART but not supported... then I did "atacontrol list" again and saw that the line about ad0 have changed to something like this: Master: ad0 ATA/ATAPI revision 0 or similar. After some digging and comparing the way "IOCATADEVICES" and "IOCATAGPARM" work I saw (probably) bogus ata_getparam() call. After removing this call to ata_getparam() everything work as expected (atleast that's what it looks like for ~30 min run). "atacontrol cap ad0" shows right results and doesn't screw the device parameters. I just hope that this doesn't break something else but I doubt it coz it just gets info and doesn't set anything. >How-To-Repeat: In description. >Fix: --- ata-all.c.old Sat Jul 1 04:10:30 2006 +++ ata-all.c Sat Jul 1 04:40:26 2006 @@ -505,7 +505,6 @@ return error; case IOCATAGPARM: - ata_getparam(atadev, 0); bcopy(&atadev->param, params, sizeof(struct ata_params)); return 0;