From owner-svn-src-head@freebsd.org Thu May 17 19:40:27 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D35BCEDE84E for ; Thu, 17 May 2018 19:40:26 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic311-14.consmr.mail.bf2.yahoo.com (sonic311-14.consmr.mail.bf2.yahoo.com [74.6.131.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6222C7314F for ; Thu, 17 May 2018 19:40:26 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1526586020; bh=aZQsUn32Ow95ivXHER6K7AaNOefRqeayS5PLilWg3s0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=TNPKvcb1OTA2aIo52Wsur0FHrNHeve9P1EUnPeCMLui5QHMJkLWkKMrIkA4/yvo411q9Uzg9aM4HL3xOVEh8uMCJ3OwcmKuo8ccb3b3N4MuDZBwoB0gDA8opGaDYWCPI+SJGAVJKtrTesH5GAWvFvDxO1jZyeCnCa7VSGohBKCYoIKeR9hWeyhDWp14PFM4APXNUfjzWtdQS1trxjuqJEjtIN3xyd5RjzBLDVA9VQWMivx/d7hx/FfjIzy9lRN0896CbcCkxfZ0A80qljEvs3gk5o/Vr3S1wV+e8gEhwcOWnxnUyJUb5gpSk/PAyop2I1UMBH1jHGGQvUYdvlkqUHQ== X-YMail-OSG: sVlptcYVM1lT399iDWXf61R2kswt0rMVYpHwCGHBIduJKyakpyPVmoTuWkDdgwb pSRpVqtwComyLoPBqAGGILthUDRQDRcBPFvFaonoK8W8V1tt7jYb4k4wJ8_6AyMN64Coj7SyacTe pb0sAFB.FJpeGjXeJJlIkgedYqzXe3cmCcOp7Vdb4l39j8eoNlFacQU9mryO1WG7Jfq5ZQ1rgx_D KMxtJhqgHj.4jMaCHJ7HnDJh50g37s0hBsGywkEPnWalfJIzPmPrx8J_7erM6mlLSeeIBGfyBbqU bC2mYOqRwWbm65nwBIH5oM87KeZUMyweLkTwjdrUglpnHtsxR0kXf2rZTi5uw5TCGpjvjXuY9hHE kLMkFRpkkZQNGiRO1Yga1Kuhy3RyBVh68zPEsqXeHmfbsk1E2XPL8FubW8KtAPyLOHchpzJQRpEL 2OetcZSpNZVlPGt3xkhQXwgR2SuNt2pvX.6.OelTF7SputO7R7SgV6avwxqjOjJCd8fqgPNGyn1. 4O7Vb_C8mQvzbLydsjYibIPfMIobfkeqfWysrKHGTyvBz1efN7azedP_YbD3qFjquxpJpCEVwOiv 4lz4.CvHE3yYI9dN80guRlwVYkPyASOTS8CObVCDWYqrdfCMA0FpMmGkMc_bDdrGHY7U- Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Thu, 17 May 2018 19:40:20 +0000 Received: from 181.52.72.201 (EHLO [192.168.0.6]) ([181.52.72.201]) by smtp428.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 213f6f77bc66fac2f162937deaceb849; Thu, 17 May 2018 19:40:16 +0000 (UTC) Subject: Re: svn commit: r333745 - in head/sys/contrib/ck: include src To: Matthew Macy Cc: Emmanuel Vadot , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201805171814.w4HIEA0F079835@repo.freebsd.org> <20180517203856.aa6b8b241e23b9c07483232b@bidouilliste.com> <17058056-6b70-e918-dab8-63951d1bfbbd@FreeBSD.org> <20180517212757.84c7b02060ca8f86e56dbee9@bidouilliste.com> <11fb642a-d334-bd7d-be4f-b1aa181b8eb2@FreeBSD.org> From: Pedro Giffuni Organization: FreeBSD Project Message-ID: <41ae57bd-2c49-97cd-1f46-2644519a95e6@FreeBSD.org> Date: Thu, 17 May 2018 14:40:13 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 19:40:27 -0000 On 17/05/2018 14:35, Matthew Macy wrote: > On Thu, May 17, 2018 at 12:32 PM, Pedro Giffuni wrote: >> >> On 17/05/2018 14:27, Emmanuel Vadot wrote: >>> On Thu, 17 May 2018 14:20:05 -0500 >>> Pedro Giffuni wrote: >>> >>>> On 17/05/2018 14:12, Matthew Macy wrote: >>>>> How do I avoid problems while allowing timely updates? >>>>> >>>>> -M >>>>> >>>>> On Thu, May 17, 2018 at 11:38 AM, Emmanuel Vadot >>>>> wrote: >>>>>> Hi Matt, >>>>>> >>>>>> On Thu, 17 May 2018 18:14:10 +0000 (UTC) >>>>>> Matt Macy wrote: >>>>>> >>>>>>> Author: mmacy >>>>>>> Date: Thu May 17 18:14:10 2018 >>>>>>> New Revision: 333745 >>>>>>> URL: https://svnweb.freebsd.org/changeset/base/333745 >>>>>>> >>>>>>> Log: >>>>>>> ck: add support for executing callbacks outside of main poll loop >>>>>>> >>>>>>> Pull in change from upstream >>>>>>> deca119d14bfffd440770eb67cbdbeaf7b57eb7b >>>>>>> >>>>>>> | ck_epoch: introduce ck_epoch_deferred >>>>>>> | >>>>>>> | Allow for deferral to occur outside epoch poll critical loop >>>>>>> (which may access per-CPU structures). >>>>>>> | >>>>>>> >>>>>>> Approved by: sbruno >>>>>>> >>>>>>> Modified: >>>>>>> head/sys/contrib/ck/include/ck_epoch.h >>>>>>> head/sys/contrib/ck/src/ck_epoch.c >>>>>>> >>>>>> CK was imported in vendor-sys/ck, commiting directly into head will >>>>>> cause some problems in the future. >>>> Actually ... committing to head is fine: some things just have to be >>>> fixed. >>> This is not true, it can cause a lot of problems with futures updates >>> if the change isn't in the vendor repo. >> OK ... I meant generally you can. The catch here is that the change was >> already upstream so it should have been done in the vendor area and then >> merged. It's best to fix this properly now. >> >> Sorry for misguiding. >> > I'm happy to comply - just point me at the fine manual. > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/subversion-primer.html Section 5.4.4 (Vendor patches). Cheers, Pedro.