From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 19:04:33 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7ACBF106568B for ; Tue, 16 Feb 2010 19:04:33 +0000 (UTC) (envelope-from emaste@freebsd.org) Received: from mail2.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by mx1.freebsd.org (Postfix) with ESMTP id 440C48FC20 for ; Tue, 16 Feb 2010 19:04:33 +0000 (UTC) Received: from labgw2.phaedrus.sandvine.com ([192.168.3.11]) by mail2.sandvine.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 16 Feb 2010 13:52:29 -0500 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 10332) id DA9B511714; Tue, 16 Feb 2010 13:52:30 -0500 (EST) Date: Tue, 16 Feb 2010 13:52:30 -0500 From: Ed Maste To: Attilio Rao Message-ID: <20100216185230.GA58974@sandvine.com> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> User-Agent: Mutt/1.4.2.1i X-OriginalArrivalTime: 16 Feb 2010 18:52:29.0321 (UTC) FILETIME=[30620F90:01CAAF39] Cc: FreeBSD Arch Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:04:33 -0000 On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: > The following patch: > http://www.freebsd.org/~attilio/x86.diff > > starts the effort for having a shared sub-tree between amd64 and ia32. > In this initial pass I putted the low-hanging fruits (bios/cpufreq) > and what my customer was more interested in (isa/*) in order to > kick-off the effort and, in the future, move gradually the code there. > With the machine/isa/* cleanup about 10 files are trimmed and I'm sure > more can be achieved easilly. > There are few things to discuss. One, that I had not necessity to dig > about still, is about how to organize headers (include/). Maybe some > replication ala pc98 may be good. > > The patch is big but it is mostly added and removed files (look at the > files.X in order to understand better how files movements happened). > > Hope to see comments and reviews. > > Attilio As you'd expect I'd be very happy to see this cleanup go ahead; having essentially the same file duplicated in two places just adds maintenance burden. Upon a quick review the patch looks OK to me. I assume we'll "svn mv" the i386 files into x86 and then add the amd64 diffs, thus maintaining the history on the files in their new locations? -Ed