Date: Fri, 25 Apr 2003 15:02:47 -0700 (PDT) From: Marcel Moolenaar <marcel@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 29740 for review Message-ID: <200304252202.h3PM2lD2065881@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=29740 Change 29740 by marcel@marcel_nfs on 2003/04/25 15:01:57 Remove emulating the MBR::type attribute. There never really was a need for it and it currently causes breakages because we don't emulate the recently (for some definition of recently) added MBR::offset. Affected files ... .. //depot/projects/ia64/sys/geom/geom_gpt.c#18 edit Differences ... ==== //depot/projects/ia64/sys/geom/geom_gpt.c#18 (text+ko) ==== @@ -79,28 +79,8 @@ static int g_gpt_start(struct bio *bp) { - struct uuid freebsd = GPT_ENT_TYPE_FREEBSD; - struct g_provider *pp = bp->bio_to; - struct g_geom *gp = pp->geom; - struct g_slicer *gsp = gp->softc; - struct g_gpt_softc *gs = gsp->softc; - u_int type; - if (bp->bio_cmd != BIO_GETATTR) - return (0); - - /* - * XXX: this is bogus. The BSD class has a strong dependency on - * the MBR/MBREXT class, because it asks for an attribute that's - * specific to the MBR/MBREXT class and the value of the attribute - * is just as specific to the MBR class. In an extensible scheme - * a geom would ask another geom if it could possible accomodate a - * class and the answer should be yes or no. Now we're forced to - * emulate a MBR class :-/ - */ - type = (memcmp(&gs->part[pp->index]->ent_type, &freebsd, - sizeof(freebsd))) ? 0 : 165; - return ((g_handleattr_int(bp, "MBR::type", type)) ? 1 : 0); + return (0); } static void
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200304252202.h3PM2lD2065881>