From owner-cvs-src@FreeBSD.ORG Fri Aug 27 23:33:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F105D16A4CE; Fri, 27 Aug 2004 23:33:16 +0000 (GMT) Received: from gw.Awfulhak.org (awfulhak.demon.co.uk [80.177.173.150]) by mx1.FreeBSD.org (Postfix) with ESMTP id 231E843D3F; Fri, 27 Aug 2004 23:33:16 +0000 (GMT) (envelope-from brian@Awfulhak.org) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.12.11/8.12.11) with SMTP id i7RNXAWr012021; Sat, 28 Aug 2004 00:33:10 +0100 (BST) (envelope-from brian@Awfulhak.org) Date: Sat, 28 Aug 2004 00:33:09 +0100 From: Brian Somers To: "Justin T. Gibbs" Message-Id: <20040828003309.2796b8f3@dev.lan.Awfulhak.org> In-Reply-To: <200408272125.i7RLPG3K076074@repoman.freebsd.org> References: <200408272125.i7RLPG3K076074@repoman.freebsd.org> X-Mailer: Sylpheed-Claws 0.9.12 (GTK+ 1.2.10; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.64 X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on gw.lan.Awfulhak.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/isa psm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2004 23:33:17 -0000 On Fri, 27 Aug 2004 21:25:16 +0000 (UTC), "Justin T. Gibbs" wrote: > gibbs 2004-08-27 21:25:16 UTC > > FreeBSD src repository > > Modified files: > sys/isa psm.c > Log: > Improve sync recovery algorithm: > o Remove PSM_SYNCERR_THRESHOLD1. This value specified how many sync > errors were required before the mouse is re-initialised. > Re-initialisation is now done after (packetsize * 2) sync errors as > things aren't likely to improve after that. > > o Reset lastinputerror when re-initialisation occurs. We don't want > to continue to drop data after re-initialisation. > > o Count the number of failed packets independently of the syncerrors > statistic. syncerrors is useful for recovering sync within a single > packet. pkterrors allows us to detect when the mouse changes its > packet mode due to some external event (e.g. KVM switch). > > o Reinitialize the mouse if we see more than psmpkterrthresh errors > during the validation period. The validation period begins as soon > as a sync error is detected and continues until psmerrsecs/msecs > time has elapsed. The defaults for these two values force a reset > if we see two packet errors in a 2 second period. This allows rapid > detection of packet framing errors caused by the mouse changing packet > modes. > > o Export psmpkterrthresh as a sysctl > > o Export psmloglevel as a sysctl. > > o Enable more debugging code to be enabled at runtime via psmloglevel. > > o Simplify verbose conditioned loging by using a VLOG macro. > > o Add several comments describing the sync recovery algorithm of > this driver. > > Large Portions by: Brian Somers > Inspired and Frustrated by: Belkin KVMs > Reviewed by: njl, philip > > Revision Changes Path > 1.80 +120 -98 src/sys/isa/psm.c Good stuff - thanks for all your work! -- Brian Don't _EVER_ lose your sense of humour !