From owner-svn-src-all@FreeBSD.ORG Wed Nov 14 16:27:37 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D51CF33A for ; Wed, 14 Nov 2012 16:27:37 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 383628FC12 for ; Wed, 14 Nov 2012 16:27:37 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id gg13so694262lbb.13 for ; Wed, 14 Nov 2012 08:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=ACkUCZHIXUa8x9PYVOnQq9TgyiHpBwBhRVXs75O3jPw=; b=nZ27AGASWclH9fIQMc1hKIoupQlK7evL7bpYrpG/ARKxKU3K84zJdNUAoopuRpZJ4f fXcxcY7AJHrzAW55xlxJrPFakEy3btISNgQWQD8rWyOMGDTeb1coooVZt0cc4ry8I82y jgJy1SQ4BmLXAhZHFVidAI59ubr8gAKgjwEBc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=ACkUCZHIXUa8x9PYVOnQq9TgyiHpBwBhRVXs75O3jPw=; b=JYV6RBDgLUIB18EIrra6FKInkt7RyprZUkNCiu6l+70EC2bD9efHFTclZ0S+ImGVaD iYkEygsjGMnQyze3sVQJDY1blOR0gniwau4qAWRq+9FkW7BPTowTRnM05sCWaMotvNEY lf9QJbtCK9dGLHkzcM5Cme0e3/nTLPLPkCkIXMyu+t4T6bPEXntQ6j9h4VSECiXEHrJM n9xJcOg9dTeFui/TSzqwEzDkJrrsc5FQw/bN6XWFve8Cz4dD7+XWf/GeennizyQQKDEQ c5vKw/+78z21NMfmAXGJ/6/AtJMoPhgsFITqPJlMW2vHfF2tRyeIa0pnCvfueH9e9quH TiGg== Received: by 10.112.13.140 with SMTP id h12mr11125725lbc.12.1352910456084; Wed, 14 Nov 2012 08:27:36 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.166 with HTTP; Wed, 14 Nov 2012 08:27:05 -0800 (PST) In-Reply-To: References: <201211140805.qAE85MHU031099@svn.freebsd.org> <50A364AE.6060205@freebsd.org> <20121114093236.GJ28213@FreeBSD.org> From: Eitan Adler Date: Wed, 14 Nov 2012 11:27:05 -0500 X-Google-Sender-Auth: JH6xCm5Qg8MUFjG9FOJQip2_dOk Message-ID: Subject: Re: svn commit: r243019 - head/sbin/route To: Ben Kaduk Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQm0qC4rDbFrtGpK5zPT35NEFqOBryy7Y1vdFtLIMC57hFKfe7V2d2lRZbNnavF6mQEInViZ Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , Andre Oppermann , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2012 16:27:38 -0000 On 14 November 2012 11:12, Ben Kaduk wrote: > On Wed, Nov 14, 2012 at 4:32 AM, Gleb Smirnoff wrote: >> A> Can the IN_CLASS[A-C]_NET... definitions go away as well? >> >> They are defines that don't generate any code. >> >> Also, on this mailing list I've promised once not to remove them :) > > I'm glad you remember :) Perhaps a comment indicating they shouldn't be removed should be added? > Andre, they are used (for better or for worse) in a multi-site > database synchronization protocol that currently works portably across > operating systems. Removing them would change the semantics of that > protocol in a subtle way that might introduce breakage. Which one? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams