From owner-freebsd-bugs@FreeBSD.ORG Thu Dec 22 20:00:26 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F32CA106564A for ; Thu, 22 Dec 2011 20:00:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9C8E28FC12 for ; Thu, 22 Dec 2011 20:00:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBMK0Qp2020714 for ; Thu, 22 Dec 2011 20:00:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBMK0Qlj020713; Thu, 22 Dec 2011 20:00:26 GMT (envelope-from gnats) Resent-Date: Thu, 22 Dec 2011 20:00:26 GMT Resent-Message-Id: <201112222000.pBMK0Qlj020713@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan McGregor Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD07E10656B2 for ; Thu, 22 Dec 2011 19:54:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id AB7458FC15 for ; Thu, 22 Dec 2011 19:54:56 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBMJsuHd047099 for ; Thu, 22 Dec 2011 19:54:56 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pBMJsuwo047098; Thu, 22 Dec 2011 19:54:56 GMT (envelope-from nobody) Message-Id: <201112221954.pBMJsuwo047098@red.freebsd.org> Date: Thu, 22 Dec 2011 19:54:56 GMT From: Dan McGregor To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/163545: Return of uninitialized value in Chelsio T3 driver X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 20:00:27 -0000 >Number: 163545 >Category: kern >Synopsis: Return of uninitialized value in Chelsio T3 driver >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 22 20:00:26 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Dan McGregor >Release: 9.0-PRERELEASE >Organization: >Environment: FreeBSD shadrach.dyndns.org 9.0-PRERELEASE FreeBSD 9.0-PRERELEASE #8 r228275: Mon Dec 5 14:05:35 CST 2011 dan@shadrach.dyndns.org:/usr/obj/usr/src9/sys/SHADRACH amd64 >Description: In the Chelsio T3 driver there is an uninitialized value returned by aq100x_power_down in sys/dev/cxgb/common/cxgb_aq100x.c. It appears that the intended return value is err, not v. >How-To-Repeat: I don't know of any problems that develop because of this problem, though it seems that it's possible for it to fail. >Fix: It looks like the value that should be returned is err, not (v). Index: sys/dev/cxgb/common/cxgb_aq100x.c =================================================================== --- sys/dev/cxgb/common/cxgb_aq100x.c (révision 228798) +++ sys/dev/cxgb/common/cxgb_aq100x.c (copie de travail) @@ -232,7 +232,7 @@ err = t3_mdio_change_bits(phy, MDIO_DEV_PMA_PMD, MII_BMCR, BMCR_PDOWN, off ? BMCR_PDOWN : 0); if (err || off) - return (v); + return (err); msleep(300); do { >Release-Note: >Audit-Trail: >Unformatted: