From nobody Sat Feb  4 14:03:23 2023
X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P8Dkz6vDkz3nR8M;
	Sat,  4 Feb 2023 14:03:23 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4P8Dkz6HgGz3rm2;
	Sat,  4 Feb 2023 14:03:23 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1675519403;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=IftE7gVcISAvag4WsKBr9S/LB9YYEEk3a9Lt+CxaHWA=;
	b=AS5ScRM0P/1c03PPFvSw4YT0VYZpG9yosBVfEjaIB/ZXl7jdD6l79/PYvO31siiu8Tmk+r
	KEgkRmx4Lvm6tJG0AyhVcBbNfniV4dMUPorQ3mr6Js8mYT/45UqAt+JRankjjXuIYDyf6L
	Wk2ZZog0bHfRJnKE1PWx9889DvSdrqUR58pkw5unTAlnvbk7lcGyQBbrnH/72iP8GeMvPz
	XIdcNOHia0CTh4+7i0Yrd16EYwjcqw0luBEWn1OHMxUDNxbp3UgzFZoG4cOL9tO//tTnhH
	ahC/XGQKUHjtvpEbk3uL2RwyIFFskUzxEN6d9kK4oUouGqWI7JUcjkziRUHgfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1675519403;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=IftE7gVcISAvag4WsKBr9S/LB9YYEEk3a9Lt+CxaHWA=;
	b=Eb3aSRSxjauzttGZLJaspyK6rwrG5uZZgRPUbnj/DZwq+spphopaYK6BRjLO6D3QYGi04o
	8uS4hKBRfyR0KDTwMcroMGpe4/8FDpFeQNBoTOrXTwAN0hNo1Zn8/zk51T84CoPs3nzylG
	zf0w2WcmEXtmZ907Qh5OYBTuHxDypYbMOZy7lPv1+O9M4bqaGqV60yuWy4SJodY4enFBis
	CpARRRs0nCRWFmbzMhoYmXjnjBlEjNE+nJz/XL4i+mWwWIgf+CHgl1slRTlcIEG4iSesbB
	/NFe8WGvUnC5j33mbVU75Qv9Nlv9j2XiWO2/jyiTbcds27D7GihMDMuO1oOPqA==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675519403; a=rsa-sha256; cv=none;
	b=h4OU4X/GSccmyR5fGThXQXjz05nyfsKym9LDFN+u8ZLUj6z7nLMsXGNvjCcheLRQE0x1zg
	D3Rq/xkdHgnl35z/gkm53MZoyOaknB9SEFutzvzCV49sdgrj64a8uMEoQF8cf6/HKuwu2f
	QzAvORzdCS1VNjiRuFYJjrDkwR2GDY/IUHbqW8fRrS0qE/6DgiIP0MvjH16B82vDV0JkN2
	1lP2hfg60+A9ny9GmJ7hGBJZIT8d09feYhKZmHByeN3K44/Kp85w31LQW3qqCUcAHHEIP7
	8iBFM2hGGZWjkJPywuuEDDIQ6zYBQdntyPkEsUWUY20khSsSBHceGRzYsBoxJg==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id A925011D74; Sat,  4 Feb 2023 14:03:23 +0000 (UTC)
Date: Sat, 4 Feb 2023 14:03:23 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: "Sergey A. Osokin" <osa@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
	dev-commits-ports-main@freebsd.org
Subject: Re: git: 70d1f3fc4b3d - main - net-im/telegram-desktop: update 4.5.3
 -> 4.6.0
Message-ID: <Y95lqxxJLW68Jsjw@FreeBSD.org>
References: <202302040214.3142E3r5010339@gitrepo.freebsd.org>
List-Id: Commit messages for all branches of the ports repository <dev-commits-ports-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all
List-Help: <mailto:dev-commits-ports-all+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-all@freebsd.org
X-BeenThere: dev-commits-ports-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202302040214.3142E3r5010339@gitrepo.freebsd.org>
X-ThisMailContainsUnwantedMimeParts: N

On Sat, Feb 04, 2023 at 02:14:03AM +0000, Sergey A. Osokin wrote:
> commit 70d1f3fc4b3df639b8f7520636b836222d242399
> 
>   net-im/telegram-desktop: update 4.5.3 -> 4.6.0

Thanks!  One minor observation/question...

> -.include <bsd.port.pre.mk>
> +.include <bsd.port.options.mk>
>  
> -.if ${COMPILER_VERSION} < 130
> -LLVM_VER=	13
> -BUILD_DEPENDS+=	clang${LLVM_VER}:devel/llvm${LLVM_VER}
> -CC=		${LOCALBASE}/bin/clang${LLVM_VER}
> -CXX=		${LOCALBASE}/bin/clang++${LLVM_VER}
> +.if ${OSVERSION} > 1400000
> +USES+=	llvm:build
> +CC=	${_LLVM_MK_PREFIX}/bin/clang
> +CPP=	${_LLVM_MK_PREFIX}/bin/clang-cpp
> +CXX=	${_LLVM_MK_PREFIX}/bin/clang++

Leading underscore suggests _LLVM_MK_PREFIX is private, exported
version is LLVM_PREFIX, why wasn't it used here instead?

./danfe