From owner-freebsd-toolchain@freebsd.org Thu Nov 23 05:02:49 2017 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B0362DDC201 for ; Thu, 23 Nov 2017 05:02:49 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-142.reflexion.net [208.70.210.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 652097BC92 for ; Thu, 23 Nov 2017 05:02:48 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 29545 invoked from network); 23 Nov 2017 04:36:02 -0000 Received: from unknown (HELO mail-cs-01.app.dca.reflexion.local) (10.81.19.1) by 0 (rfx-qmail) with SMTP; 23 Nov 2017 04:36:02 -0000 Received: by mail-cs-01.app.dca.reflexion.local (Reflexion email security v8.40.3) with SMTP; Wed, 22 Nov 2017 23:36:02 -0500 (EST) Received: (qmail 19871 invoked from network); 23 Nov 2017 04:36:02 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 23 Nov 2017 04:36:02 -0000 Received: from [192.168.1.25] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id 8F0F7EC814E; Wed, 22 Nov 2017 20:36:01 -0800 (PST) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: poudriere-devel -S SRCPATH : no longer supported? (/usr/ports/ -r454407 vintage example) Message-Id: <39DB21B0-F31B-4B64-8A53-74EB46D5DB0C@dsl-only.net> Date: Wed, 22 Nov 2017 20:36:00 -0800 Cc: FreeBSD Toolchain To: Bryan Drewery , FreeBSD Ports X-Mailer: Apple Mail (2.3273) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 05:02:49 -0000 As evidence only two lines of jail.sh reference SRCPATH other than where -S assigns to it: # grep "SRCPATH" /usr/local/share/poudriere/jail.sh [ -z "${SRCPATH}" ] && DISTS="${DISTS} src" [ -n "$SRCPATH" ] && jset ${JAILNAME} srcpath ${SRCPATH} SRCPATH=${OPTARG} Also, every non-comment instance of /usr/src in jail.sh is preceded by just ${JAILMNT} or ${SRC_BASE} or by nothing: # grep "\/usr\/src" /usr/local/share/poudriere/jail.sh | more SRC_BASE="${JAILMNT}/usr/src" export SRC_BASE=${JAILMNT}/usr/src # Otherwise it's the older broken one, so use the host /usr/src : ${XDEV_SRC:=/usr/src} msg_n "Copying ${SRC_BASE} to ${JAILMNT}/usr/src..." mkdir -p ${JAILMNT}/usr/src if [ -f ${SRC_BASE}/usr/src/.cpignore ]; then cpdup -i0 ${cpignore_flag} ${SRC_BASE} ${JAILMNT}/usr/src SRC_BASE="${JAILMNT}/usr/src" It leaves me wondering if some notation like: ${SRCPATH:-${JAILMNT}}/usr/src should be in use in some places where ${JAILMNT}/usr/src is now in use. I'm no so sure that the analogous is appropriate for the one example of : ${SRC_BASE}/usr/src === Mark Millard markmi at dsl-only.net