From owner-freebsd-current@FreeBSD.ORG  Fri Apr 11 11:17:34 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 864F737B401
	for <current@freebsd.org>; Fri, 11 Apr 2003 11:17:34 -0700 (PDT)
Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C168B43F93
	for <current@freebsd.org>; Fri, 11 Apr 2003 11:17:33 -0700 (PDT)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h3BIHQa71267;
	Fri, 11 Apr 2003 14:17:26 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Fri, 11 Apr 2003 14:17:26 -0400 (EDT)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Ian Freislich <ianf@za.uu.net>
In-Reply-To: <667.1050063441@wcom.com>
Message-ID: <20030411141630.B37530-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: current@freebsd.org
Subject: Re: ULE nice bugs are fixed. 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Apr 2003 18:17:34 -0000


On Fri, 11 Apr 2003, Ian Freislich wrote:

> Jeff Roberson wrote:
> > Could those of you that have been testing it so far please try it out
> > again and let me know how it feels?
>
> ../../../kern/sched_ule.c: In function `sched_clock':
> ../../../kern/sched_ule.c:927: structure has no member named `ksq_rslice'
>
> $FreeBSD: src/sys/kern/sched_ule.c,v 1.22 2003/04/11 03:47:14 jeff Exp $
>
> Is this the right version of the file?  I don't know enough about
> the scheduler to be sure this is the right fix, but I suspect it
> should be kseq->ksq_rslices if the struct kseq definition is anything
> to go by.
>
> --- sched_ule.c.orig    Fri Apr 11 12:10:56 2003
> +++ sched_ule.c Fri Apr 11 11:45:02 2003
> @@ -924,7 +924,7 @@
>          */
>         ke->ke_slice--;
>  #ifdef SMP
> -       kseq->ksq_rslice--;
> +       kseq->ksq_rslices--;
>  #endif
>
>         if (ke->ke_slice > 0)
>
>
> It compiles after this change, but didn't come back after reboot.
> I'm no where near the machine at the moment, so I don't know why
> it hasn't come up.
>
> Ian

Oh, right, you did the right thing there.  I just didn't have a SMP
machine available for testing the last round of changes.  I'll look into
this.

Cheers,
Jeff