From owner-p4-projects@FreeBSD.ORG Fri Jan 4 18:44:39 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 2F64216A420; Fri, 4 Jan 2008 18:44:39 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E986016A41B for ; Fri, 4 Jan 2008 18:44:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 8F12213C45D for ; Fri, 4 Jan 2008 18:44:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8q) with ESMTP id 227301258-1834499 for multiple; Fri, 04 Jan 2008 13:42:41 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id m04IiTF4041197; Fri, 4 Jan 2008 13:44:29 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "M. Warner Losh" Date: Fri, 4 Jan 2008 13:43:18 -0500 User-Agent: KMail/1.9.6 References: <200801041711.m04HBGPG029002@repoman.freebsd.org> <20080104.111926.-108774279.imp@bsdimp.com> In-Reply-To: <20080104.111926.-108774279.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801041343.19320.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 04 Jan 2008 13:44:29 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/5363/Fri Jan 4 08:37:27 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: gonzo@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 132497 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2008 18:44:39 -0000 On Friday 04 January 2008 01:19:26 pm M. Warner Losh wrote: > In message: <200801041711.m04HBGPG029002@repoman.freebsd.org> > Oleksandr Tymoshenko writes: > : http://perforce.freebsd.org/chv.cgi?CH=132497 > : > : Change 132497 by gonzo@gonzo_jeeves on 2008/01/04 17:11:07 > : > : o I believe MK_ZFS is more appropriate variable to be checked > : in this case. > > I thought this was more a case of 'exclude all CDDL code' rather than > being tied to ZFS. > > Warner I dunno, I think gonzo@ might be right. It's ZFS support for fstat and I think disabling CDDL would disable ZFS as a side effect? > : Affected files ... > : > : .. //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 edit > : > : Differences ... > : > : ==== //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 (text+ko) ==== > : > : @@ -13,7 +13,7 @@ > : > : CFLAGS+=-D_KVM_VNODE > : > : -.if ${MK_CDDL} != "no" > : +.if ${MK_ZFS} != "no" > : CFLAGS+= -DZFS > : OBJS+= zfs/zfs.o > : SUBDIR= zfs > : > -- John Baldwin