From owner-freebsd-current@FreeBSD.ORG  Sat Sep 20 17:14:52 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 45EC01065673
	for <freebsd-current@freebsd.org>; Sat, 20 Sep 2008 17:14:52 +0000 (UTC)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27])
	by mx1.freebsd.org (Postfix) with ESMTP id F11648FC0C
	for <freebsd-current@freebsd.org>; Sat, 20 Sep 2008 17:14:51 +0000 (UTC)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from localhost (amavis.str.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id F25D241C66F;
	Sat, 20 Sep 2008 18:55:05 +0200 (CEST)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([62.111.66.27])
	by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id SUdq3YAJD3O2; Sat, 20 Sep 2008 18:55:05 +0200 (CEST)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id 9A79841C65F; Sat, 20 Sep 2008 18:55:05 +0200 (CEST)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id 9870C44487F;
	Sat, 20 Sep 2008 16:52:18 +0000 (UTC)
Date: Sat, 20 Sep 2008 16:52:18 +0000 (UTC)
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: Diego Depaoli <trebestie@gmail.com>
In-Reply-To: <83e5fb980809200853s2e1bbb19i7c0821776936ab46@mail.gmail.com>
Message-ID: <20080920165125.B65801@maildrop.int.zabbadoz.net>
References: <83e5fb980809200158h4650ad2ci55883ef93e69d1d8@mail.gmail.com>
	<200809201237.48903.shoesoft@gmx.net>
	<83e5fb980809200853s2e1bbb19i7c0821776936ab46@mail.gmail.com>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-current@freebsd.org, Stefan Ehmann <shoesoft@gmx.net>
Subject: Re: Today build breaks nvidia driver
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Sep 2008 17:14:52 -0000

On Sat, 20 Sep 2008, Diego Depaoli wrote:

> 2008/9/20 Stefan Ehmann <shoesoft@gmx.net>:
>> On Saturday 20 September 2008 10:58:49 Diego Depaoli wrote:
>>> Hi all,
>>> I've some trouble building nvidia driver after today world/kernel.
>>
>>> cc1: warnings being treated as errors
>>> nvidia_os.c: In function 'os_is_administrator':
>>> nvidia_os.c:168: warning: implicit declaration of function 'suser'
>>> nvidia_os.c:168: warning: nested extern declaration of 'suser'
>>> *** Error code 1
>>
>> Ran across this problem yesterday:
>>
>> As a quick hack you can change one line in nvidia_os.c:
>>
>>  BOOL NV_API_CALL os_is_administrator(PHWINFO pDev)
>>  {
>> -    return suser(CURTHREAD) ? FALSE : TRUE;
>> +    return priv_check(CURTHREAD, PRIV_DRIVER) ? FALSE : TRUE;
>>  }

that should be conditionalized with __FreeBSD_version as Attilio
had said (just mentioning again before this patch hits ports@ ;)

-- 
Bjoern A. Zeeb              Stop bit received. Insert coin for new game.