From owner-svn-src-stable-7@FreeBSD.ORG Wed Apr 1 18:47:02 2009 Return-Path: Delivered-To: svn-src-stable-7@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC4041065673; Wed, 1 Apr 2009 18:47:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 852BA8FC15; Wed, 1 Apr 2009 18:47:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id 258C046B1A; Wed, 1 Apr 2009 14:47:02 -0400 (EDT) Received: from localhost (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n31IkuYT041946; Wed, 1 Apr 2009 14:46:56 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Dmitry Chagin Date: Wed, 1 Apr 2009 14:46:51 -0400 User-Agent: KMail/1.9.7 References: <200903290807.n2T87b4D025770@svn.freebsd.org> In-Reply-To: <200903290807.n2T87b4D025770@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904011446.51822.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 01 Apr 2009 14:46:56 -0400 (EDT) X-Virus-Scanned: ClamAV 0.94.2/9195/Wed Apr 1 12:49:01 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r190520 - in stable/7/sys: . amd64/amd64 amd64/linux32 arm/arm compat/ia32 compat/svr4 contrib/pf dev/ath/ath_hal dev/cxgb i386/i386 i386/linux ia64/ia64 kern powerpc/powerpc sparc64/sp... X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2009 18:47:03 -0000 On Sunday 29 March 2009 4:07:37 am Dmitry Chagin wrote: > Author: dchagin > Date: Sun Mar 29 08:07:36 2009 > New Revision: 190520 > URL: http://svn.freebsd.org/changeset/base/190520 > > Log: > Merge from head to stable/7: > > r189771: > Implement new way of branding ELF binaries by looking to a > ".note.ABI-tag" section. > > The search order of a brand is changed, now first of all the > ".note.ABI-tag" is looked through. > > Move code which fetch osreldate for ELF binary to check_note() handler. I think this breaks the ABI of older ELF ABI kernel modules (e.g. older linux.ko binaries) since it changes the layout of the 'ElfN(Brandinfo)' structure. I think you can fix this by making the following changes in 7.x only: 1) Move the new field (brand_note) to the end of the structure. 2) Add a new flag BI_BRAND_NOTE (or some such) that indicates that the brandnote pointer is valid. Only use the brandnote field if the new flag is set and set it in all the new places that now have notes. Old modules won't have the flag set, so the new field (which would really be garbage) would be ignored. -- John Baldwin