From owner-cvs-all@FreeBSD.ORG Sun Apr 30 02:30:57 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA4FC16A400; Sun, 30 Apr 2006 02:30:57 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F2E643D45; Sun, 30 Apr 2006 02:30:54 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k3U2UqLa019829; Sat, 29 Apr 2006 20:30:53 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <44542163.9000001@samsco.org> Date: Sat, 29 Apr 2006 20:30:59 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20051230 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Bjoern A. Zeeb" References: <200604280317.k3S3Hb3L017882@repoman.freebsd.org> <1146195791.40894.6.camel@shumai.marcuscom.com> <44524F85.5000508@FreeBSD.org> <20060429081427.J13011@maildrop.int.zabbadoz.net> <445407B0.5000000@FreeBSD.org> <20060430012542.B13011@maildrop.int.zabbadoz.net> In-Reply-To: <20060430012542.B13011@maildrop.int.zabbadoz.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: Maxim Sobolev , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sk if_sk.c if_skreg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Apr 2006 02:30:57 -0000 Bjoern A. Zeeb wrote: > On Sat, 29 Apr 2006, Maxim Sobolev wrote: > >> Bjoern A. Zeeb wrote: >> >>> On Fri, 28 Apr 2006, Maxim Sobolev wrote: >>> >>>> Joe Marcus Clarke wrote: >>>> >>>>> On Fri, 2006-04-28 at 03:17 +0000, Maxim Sobolev wrote: >>>>> >>>>>> sobomax 2006-04-28 03:17:37 UTC >>>>>> >>>>>> FreeBSD src repository >>>>>> >>>>>> Modified files: >>>>>> sys/dev/sk if_sk.c if_skreg.h Log: >>>>>> Add some incomplete support for Marvell Yukon EC controllers >>>>>> based on >>>>>> OpenBSD changes. With these changes, PHY part of the driver becomes >>> >>> >>> So are you going to back out your last change to sk(4)? >> >> >> Why would I? > > > because as you said it's incomplete and doesn't really help sk and > further won't help once we get myk into the tree because sk will > also successfully attach and not work for those cards then. > What was also said is that we do not want to add the code for the > PCIe (Y-II) cards to sk but want to have a different driver. > sk already has too many if() in its paths and adding different > kind of hardware to the driver won't make it any better. > > If you have time and interest in getting the PCIe chipsets working you > should have a look at the myk code posted by andre and the follow-up > comments. > > Thanks. > Does anyone have any actual specs for the YK2/YKe chips? If so, I'd be quite happy to quickly write a clean driver for it. Scott