From owner-freebsd-toolchain@freebsd.org  Mon Jun 29 13:02:40 2015
Return-Path: <owner-freebsd-toolchain@freebsd.org>
Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE98898F47B
 for <freebsd-toolchain@mailman.ysv.freebsd.org>;
 Mon, 29 Jun 2015 13:02:40 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 by mx1.freebsd.org (Postfix) with ESMTP id A27151094
 for <freebsd-toolchain@freebsd.org>; Mon, 29 Jun 2015 13:02:40 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346)
 id 9D8A8B901; Mon, 29 Jun 2015 13:02:40 +0000 (UTC)
Date: Mon, 29 Jun 2015 13:02:40 +0000
To: freebsd-toolchain@freebsd.org
From: "kib (Konstantin Belousov)" <phabric-noreply@FreeBSD.org>
Reply-to: D2933+334+e35df629633d6443@FreeBSD.org
Subject: [Differential] [Commented On] D2933: Significantly speed up ar(1) on
 UFS file systems
Message-ID: <477917a4a4027dd0b775cf010fc861e5@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2933: Significantly speed up ar(1) on UFS file systems
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-2wocyy2vsyzu2nddvuw6>
X-Phabricator-To: <PHID-USER-7dwczumdatyyxdjeiazl>
X-Phabricator-Cc: <PHID-USER-2wocyy2vsyzu2nddvuw6>
X-Phabricator-Cc: <PHID-USER-k6jzdjowb7pqtu626iin>
X-Phabricator-Cc: <PHID-USER-5dahex5ejhfmjb6awx4r>
X-Phabricator-Cc: <PHID-USER-ejmjsmhpyau7otpbjnc6>
In-Reply-To: <differential-rev-PHID-DREV-hkid5hylfsbts6yuvnph-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-hkid5hylfsbts6yuvnph-req@FreeBSD.org>
Thread-Index: OTY3MzA4YjIwYTMzODRmYTQ0NTRmMTdjYzJlIFWRQfA=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jun 2015 13:02:40 -0000

kib added inline comments.

INLINE COMMENTS
  usr.bin/ar/write.c:568 It is simpler to do
     if (s == 0)
       return;
     for (p = buf; p < buf + s; p += page_size)
        *p;
     *(volatile const char *)(buf + s - 1);
  
  I do not insist.

REVISION DETAIL
  https://reviews.freebsd.org/D2933

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: emaste, kib, eadler
Cc: kib, freebsd-toolchain-list, dim, davide