From owner-freebsd-bugs@FreeBSD.ORG  Wed Sep 19 13:30:21 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AE04F1065670
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 19 Sep 2012 13:30:21 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6D7E78FC15
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 19 Sep 2012 13:30:21 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8JDULbo024163
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 19 Sep 2012 13:30:21 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8JDULGQ024162;
	Wed, 19 Sep 2012 13:30:21 GMT (envelope-from gnats)
Resent-Date: Wed, 19 Sep 2012 13:30:21 GMT
Resent-Message-Id: <201209191330.q8JDULGQ024162@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Gareth de Vaux <freebsd@lordcow.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EA70A1065672
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 19 Sep 2012 13:26:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D5E358FC0A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 19 Sep 2012 13:26:56 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q8JDQupF036631
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 19 Sep 2012 13:26:56 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id q8JDQuAR036603;
	Wed, 19 Sep 2012 13:26:56 GMT (envelope-from nobody)
Message-Id: <201209191326.q8JDQuAR036603@red.freebsd.org>
Date: Wed, 19 Sep 2012 13:26:56 GMT
From: Gareth de Vaux <freebsd@lordcow.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/171779: make option NO_FSCHG incomplete
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Sep 2012 13:30:21 -0000


>Number:         171779
>Category:       misc
>Synopsis:       make option NO_FSCHG incomplete
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 19 13:30:21 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Gareth de Vaux
>Release:        8.3-STABLE
>Organization:
iThemba LABS
>Environment:
FreeBSD XXX 8.3-STABLE FreeBSD 8.3-STABLE #0: Wed Sep 12 22:15:43 SAST 2012     root@XXX:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
Outlined in http://lists.freebsd.org/pipermail/freebsd-stable/2012-September/069610.html

Running a make installworld with NO_FSCHG defined fails to prevent /usr/bin/passwd being installed with the schg flag.

>How-To-Repeat:
chflags -R noschg /
NO_FSCHG=true
make installworld
ls -lo /usr/bin/passwd

>Fix:
add conditional to 'afterinstall' in /usr/src/usr.bin/passwd/Makefile:

.if !defined(NO_FSCHG)
afterinstall:
        -chflags schg ${DESTDIR}${BINDIR}/passwd
.endif


>Release-Note:
>Audit-Trail:
>Unformatted: