From owner-freebsd-jail@FreeBSD.ORG Mon May 21 18:08:22 2012 Return-Path: Delivered-To: jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0756B10657D4 for ; Mon, 21 May 2012 18:08:22 +0000 (UTC) (envelope-from edschouten@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 91A9D8FC0C for ; Mon, 21 May 2012 18:08:18 +0000 (UTC) Received: by werg1 with SMTP id g1so4411255wer.13 for ; Mon, 21 May 2012 11:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; bh=0WVe2VfD6vg3Q7ed9h9A6oC8DE5iAmSClRGY/+e9eno=; b=ZtjGoOI8SqPWL2YPnLLnwJgt8Ppg5qgJrzI3b67gyJUhYdiNJGxZA4sjHQqHgDLXJy wh1KOoBHgWfXTdxF1oSOLWy33BM2P0c3yJs6U6kwFEadciNXlPc/tHwFdQB2+UIavHpQ JjkqQiMAwpemkB+YUO+Fj2Ve6qjbd1CdaCfVh+d8esixBqa5Iun7Zu1ky2p2YCrxJwfO im53afSHOd7U/oXuX8qV/602Ww+nERaoMCifftykCxi2ZbH2BvL+Pt4dpCaUR8As9Q7g EIBzTU//CtxhiitOFbrVbiUDM5BUNL8U43t+Q2eSL+47CgW8cMarEuq+iLMc+DS0Qa7G QNXA== MIME-Version: 1.0 Received: by 10.180.94.4 with SMTP id cy4mr27739374wib.2.1337623697394; Mon, 21 May 2012 11:08:17 -0700 (PDT) Sender: edschouten@gmail.com Received: by 10.223.103.197 with HTTP; Mon, 21 May 2012 11:08:17 -0700 (PDT) Date: Mon, 21 May 2012 20:08:17 +0200 X-Google-Sender-Auth: 8aJX7cUerHW0gOsIl3PePQGLcNU Message-ID: From: Ed Schouten To: jail@FreeBSD.org Content-Type: text/plain; charset=UTF-8 Cc: Subject: Breakage on 9 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2012 18:08:22 -0000 Hi, Today I was bitten by the "jail: unknown parameter: allow.nomount" bug. It seems this bug is at least more than one month old -- on 9-STABLE! Why hasn't the commit that introduced this bug been backed out? The code worked before. Now it's broken and we're waiting for an MFC period? Using a Danish (Dutch?) axe, I was able to at least get my box working again: Index: lib/libjail/jail.c =================================================================== --- lib/libjail/jail.c (revision 235725) +++ lib/libjail/jail.c (working copy) @@ -890,7 +890,7 @@ snprintf(jail_errmsg, JAIL_ERRMSGLEN, "unknown parameter: %s", jp->jp_name); errno = ENOENT; - return (-1); + return (0); } snprintf(desc.s, sizeof(desc.s), SJPARAM ".%s", nname); free(nname); -- Ed Schouten