From nobody Mon Aug 29 22:37:54 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MGlh323MBz4ZtS2; Mon, 29 Aug 2022 22:37:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MGlh31Nflz3nSf; Mon, 29 Aug 2022 22:37:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661812675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cM45XrdHVeJ2Io+xXbWO8Y3/d5bGeQ2OF9xypRpqfRg=; b=XmGGMBuqAmQ29YHA6PyX/QNABOnf5EL0raEVXU5B+VbOVZ75JGxJZbRC8igVUKq9ng61gt TM+GGm+c3FKggcPpZBtPccpWs8RnPZCEqn3mH8mhlTyzdcSM+ngrI3dW38ieZEEYCbU4wK Ris5+/YEDf/G9F8IG74h/uT7PPpR+7DBIXIkA7ox694tG7oH9d7CrTrkGgE3VMZGZhEBBW gh3wPFfAFfRWHwFYHicELUr698kFbJR6mjsgXyypkxvuCCTpsa4AkSAGKMgjQNlQXgDMEH 9mwkJ324uMk3sx1KOA0/gbL8VZcaG/8/IA8g0vM8FAhxDRfdzUfzO1eeF7qcaw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MGlh3049BzZrY; Mon, 29 Aug 2022 22:37:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 27TMbsSx023152; Mon, 29 Aug 2022 22:37:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 27TMbsJH023151; Mon, 29 Aug 2022 22:37:54 GMT (envelope-from git) Date: Mon, 29 Aug 2022 22:37:54 GMT Message-Id: <202208292237.27TMbsJH023151@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 62806a7f31e3 - main - bhyve virtio-scsi: Tidy warning and debug prints. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 62806a7f31e3b4813c4e6b70534c41f91bfe4e12 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661812675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cM45XrdHVeJ2Io+xXbWO8Y3/d5bGeQ2OF9xypRpqfRg=; b=L7ML7UwA4SsnQoWY49CyiWT+xJzMnvs9qGM/FfLFE5MhklfLuRR/WCmUrbIhjcniAHWLeZ nribfO57g270iGT7nP5aRh2LzMSjv1XEjqL8I3UBkl5aUxnByVY2kzhy5iNPkaDDSHk8/u jowhNvlTYeGv8QFPylnOy5eBMXQiykHs43LWv/rviJgTeUGps21kL3mQ+3YjHGW7aiAAJS kqdK5fXQpT+kSodwF4cW60u05uPCFfqZl8FU3BQmGtjuGvBx4Vkj2BLNE74W7YrwNKv/Mc as9ADLkLBKU7ceJldhHcgrXSrpU34BlhzX9dAJmen0LdKVQOv5QZcWPuDQ8l5w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661812675; a=rsa-sha256; cv=none; b=c9ntinenr7nXlseKZPZw17DEUky3wAGeU+o6djaFKdlq30TckEOE90KB7U+mN+08m7IzQl fMERCIyjysaSgt1h9v75rpKSWLIJvY9CMlx+5tMLKXhbvaXd4H3vGN/cpUVk4FFcYJn3uu qgyTiI1f1fma2vAzFkEhwqABt8M7QvvDvwEURRRneorWtVqrB6pqE0Ybnxq3iT8ZtI+UK8 Q/TEVGbE+zVJPLBCxqrz9W3VZGbkP++mZgokTGj3JcIcTkUtm7FbmRS4e+CTlI5SsGOK4A Ec+8/3zqr1VOKgBJgdvw2G/rMgwll5m6JkEXqMeorWjlneBJLH7O3Ry1iSGq2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=62806a7f31e3b4813c4e6b70534c41f91bfe4e12 commit 62806a7f31e3b4813c4e6b70534c41f91bfe4e12 Author: John Baldwin AuthorDate: 2022-08-29 22:35:42 +0000 Commit: John Baldwin CommitDate: 2022-08-29 22:37:15 +0000 bhyve virtio-scsi: Tidy warning and debug prints. Use a consistent prefix ("virtio-scsi: ") similar to the e1000 device model. Reviewed by: mav, emaste MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D36270 --- usr.sbin/bhyve/pci_virtio_scsi.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/usr.sbin/bhyve/pci_virtio_scsi.c b/usr.sbin/bhyve/pci_virtio_scsi.c index 6f7dceb05d92..6d867e7e3b56 100644 --- a/usr.sbin/bhyve/pci_virtio_scsi.c +++ b/usr.sbin/bhyve/pci_virtio_scsi.c @@ -88,8 +88,8 @@ __FBSDID("$FreeBSD$"); #define VIRTIO_SCSI_F_CHANGE (1 << 2) static int pci_vtscsi_debug = 0; -#define DPRINTF(params) if (pci_vtscsi_debug) PRINTLN params -#define WPRINTF(params) PRINTLN params +#define WPRINTF(msg, params...) PRINTLN("virtio-scsi: " msg, ##params) +#define DPRINTF(msg, params...) if (pci_vtscsi_debug) WPRINTF(msg, ##params) struct pci_vtscsi_config { uint32_t num_queues; @@ -289,8 +289,7 @@ pci_vtscsi_proc(void *arg) vq_endchains(q->vsq_vq, 0); pthread_mutex_unlock(&q->vsq_qmtx); - DPRINTF(("virtio-scsi: request completed", - req->vsr_idx)); + DPRINTF("request completed", req->vsr_idx); free(req); } @@ -305,7 +304,7 @@ pci_vtscsi_reset(void *vsc) sc = vsc; - DPRINTF(("vtscsi: device reset requested")); + DPRINTF("device reset requested"); vi_reset_dev(&sc->vss_vs); /* initialize config structure */ @@ -434,13 +433,13 @@ pci_vtscsi_tmf_handle(struct pci_vtscsi_softc *sc, struct sbuf *sb = sbuf_new_auto(); ctl_io_sbuf(io, sb); sbuf_finish(sb); - DPRINTF(("pci_virtio_scsi: %s", sbuf_data(sb))); + DPRINTF("%s", sbuf_data(sb)); sbuf_delete(sb); } err = ioctl(sc->vss_ctl_fd, CTL_IO, io); if (err != 0) - WPRINTF(("CTL_IO: err=%d (%s)", errno, strerror(errno))); + WPRINTF("CTL_IO: err=%d (%s)", errno, strerror(errno)); tmf->response = io->taskio.task_status; ctl_scsi_free_io(io); @@ -527,13 +526,13 @@ pci_vtscsi_request_handle(struct pci_vtscsi_queue *q, struct iovec *iov_in, struct sbuf *sb = sbuf_new_auto(); ctl_io_sbuf(io, sb); sbuf_finish(sb); - DPRINTF(("pci_virtio_scsi: %s", sbuf_data(sb))); + DPRINTF("%s", sbuf_data(sb)); sbuf_delete(sb); } err = ioctl(sc->vss_ctl_fd, CTL_IO, io); if (err != 0) { - WPRINTF(("CTL_IO: err=%d (%s)", errno, strerror(errno))); + WPRINTF("CTL_IO: err=%d (%s)", errno, strerror(errno)); cmd_wr->response = VIRTIO_SCSI_S_FAILURE; } else { cmd_wr->sense_len = MIN(io->scsiio.sense_len, @@ -622,8 +621,7 @@ pci_vtscsi_requestq_notify(void *vsc, struct vqueue_info *vq) pthread_cond_signal(&q->vsq_cv); pthread_mutex_unlock(&q->vsq_mtx); - DPRINTF(("virtio-scsi: request enqueued", - vireq.idx)); + DPRINTF("request enqueued", vireq.idx); } } @@ -695,7 +693,7 @@ pci_vtscsi_init(struct vmctx *ctx, struct pci_devinst *pi, nvlist_t *nvl) devname = "/dev/cam/ctl"; sc->vss_ctl_fd = open(devname, O_RDWR); if (sc->vss_ctl_fd < 0) { - WPRINTF(("cannot open %s: %s", devname, strerror(errno))); + WPRINTF("cannot open %s: %s", devname, strerror(errno)); free(sc); return (1); }