From owner-cvs-all@FreeBSD.ORG  Sun Sep 18 08:35:38 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AEAA716A41F;
	Sun, 18 Sep 2005 08:35:38 +0000 (GMT)
	(envelope-from damien.bergamini@free.fr)
Received: from smtp2-g19.free.fr (smtp2-g19.free.fr [212.27.42.28])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5114343D45;
	Sun, 18 Sep 2005 08:35:38 +0000 (GMT)
	(envelope-from damien.bergamini@free.fr)
Received: from COMETE (pasteur-1-82-67-68-158.fbx.proxad.net [82.67.68.158])
	by smtp2-g19.free.fr (Postfix) with SMTP id 151902583E;
	Sun, 18 Sep 2005 10:35:36 +0200 (CEST)
Message-ID: <00f701c5bc2b$faa6faf0$0300a8c0@COMETE>
From: "Damien Bergamini" <damien.bergamini@free.fr>
To: "Sam Leffler" <sam@errno.com>
References: <200509171241.j8HCf5ov019561@repoman.freebsd.org>
	<432C4C6F.80906@errno.com> <00d501c5bbc0$1e8a9240$0300a8c0@COMETE>
	<432C8486.8060808@errno.com>
Date: Sun, 18 Sep 2005 10:35:51 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.2670
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2670
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Sep 2005 08:35:38 -0000

| > No, you missed the point.  This is not a table of ieee80211_node's, but
| > just a table of the neighbours mac addresses.  Thus there is no problem
| > with reference counting, locking and such.
| > The iwi_find_txnode() function just looks for a mac address in the table
| > and returns its index (an entry is created if it was not already existing).
| 
| Sorry, you're correct, these are mac addresses and not node references. 
|  But the suggestion still holds.  You've got a separate piece of 
| per-node  information that logically belongs in a driver-private area of 
| the node.  Having it there would eliminate the table lookup; you just 
| take the node pointer and deref to get the index.  The intent of 
| driver-private node storage is to eliminate add-on tables like this.

Yeah, I already used something similar in ral for per-node rate adaptation.
But I thought it would be an overkill here for such a simple task.
Moreover, I must maintain exactly the same table in h/w, so keeping the h/w
table in sync with net80211 nodes would be a nightmare.

| Note that when I MFC'd changes in this driver recently that I did not 
| MFC any of your WME mods.  My suggestion was that you not MFC _some_ of 
| the changes; not things like fixing hidden ap handling.  re is the final 
| arbiter of what can be MFC'd.

Looks like it's already too late for BETA5 anyway ...

Damien