From owner-cvs-src@FreeBSD.ORG  Sat Dec  1 19:50:13 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 930BE16A41A
	for <cvs-src@FreeBSD.org>; Sat,  1 Dec 2007 19:50:13 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id D0A3B13C469
	for <cvs-src@FreeBSD.org>; Sat,  1 Dec 2007 19:50:12 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: (qmail invoked by alias); 01 Dec 2007 19:23:32 -0000
Received: from p54A3EDD3.dip.t-dialin.net (EHLO tron.homeunix.org)
	[84.163.237.211]
	by mail.gmx.net (mp028) with SMTP; 01 Dec 2007 20:23:32 +0100
X-Authenticated: #1673122
X-Provags-ID: V01U2FsdGVkX19h7AMhIxthUGFvMiXW1ofQk4l35PqAntk+t7hLmj
	3s/PEPZ4bzGYH3
Message-ID: <4751B4B3.6020300@gmx.de>
Date: Sat, 01 Dec 2007 20:23:31 +0100
From: Christoph Mallon <christoph.mallon@gmx.de>
User-Agent: Thunderbird 2.0.0.6 (X11/20070806)
MIME-Version: 1.0
To: Poul-Henning Kamp <phk@FreeBSD.org>
References: <200712011856.lB1Iuoiw042995@repoman.freebsd.org>
In-Reply-To: <200712011856.lB1Iuoiw042995@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
X-Y-GMX-Trusted: 0
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/include assert.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Dec 2007 19:50:13 -0000

Poul-Henning Kamp wrote:
> phk         2007-12-01 18:56:50 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     include              assert.h 
>   Log:
>   Add missing #ifndef _ASSERT_H_ protection against multiple inclusions

This change violates ANSI C:
"The assert macro is redefined according to the current state of NDEBUG 
each time that <assert.h> is included." (ISO C99 §7.2)

Please also see the comment in assert.h:
/*
  * Unlike other ANSI header files, <assert.h> may usefully be included
  * multiple times, with and without NDEBUG defined.
  */

	Christoph