From owner-svn-src-head@freebsd.org Fri Apr 6 01:08:09 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42E34F92098; Fri, 6 Apr 2018 01:08:09 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DFE3E7B2BD; Fri, 6 Apr 2018 01:08:08 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 7D91E14B01; Fri, 6 Apr 2018 01:08:02 +0000 (UTC) Subject: Re: svn commit: r332070 - in head/sys/geom: . label raid To: Sean Bruno , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201804051356.w35Duexg022529@repo.freebsd.org> From: Allan Jude Message-ID: <4cd9a49c-2d75-bfac-20df-72e8c80eded4@freebsd.org> Date: Thu, 5 Apr 2018 21:08:06 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <201804051356.w35Duexg022529@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="m1i1JxhQNEm7dh9MBpO8sdv62rRxP7VgF" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 01:08:09 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --m1i1JxhQNEm7dh9MBpO8sdv62rRxP7VgF Content-Type: multipart/mixed; boundary="XnlaW1AVcJD5GE6LFCC0nZCPKLxsauuRA"; protected-headers="v1" From: Allan Jude To: Sean Bruno , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <4cd9a49c-2d75-bfac-20df-72e8c80eded4@freebsd.org> Subject: Re: svn commit: r332070 - in head/sys/geom: . label raid References: <201804051356.w35Duexg022529@repo.freebsd.org> In-Reply-To: <201804051356.w35Duexg022529@repo.freebsd.org> --XnlaW1AVcJD5GE6LFCC0nZCPKLxsauuRA Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-04-05 09:56, Sean Bruno wrote: > Author: sbruno > Date: Thu Apr 5 13:56:40 2018 > New Revision: 332070 > URL: https://svnweb.freebsd.org/changeset/base/332070 >=20 > Log: > Squash error from geom by sizing ident strings to DISK_IDENT_SIZE. > =20 > Display attribute in future error strings and differentiate g_handlea= ttr() > error messages for ease of debugging in the future. > =20 > "g_handleattr: md1 bio_length 24 strlen 31 -> EFAULT" > =20 > Reported by: swills > Reviewed by: imp cem avg > Sponsored by: Limelight Networks > Differential Revision: https://reviews.freebsd.org/D14962 >=20 > Modified: > head/sys/geom/geom_subr.c > head/sys/geom/label/g_label_disk_ident.c > head/sys/geom/raid/md_ddf.c > head/sys/geom/raid/md_intel.c >=20 I might be missing something here, but it seems like you didn't actually change the side of struct md_s { =2E.. char ident[32]; =2E.. } And I don't see where the destination buffer went from 24 bytes to a larger value. --=20 Allan Jude --XnlaW1AVcJD5GE6LFCC0nZCPKLxsauuRA-- --m1i1JxhQNEm7dh9MBpO8sdv62rRxP7VgF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJaxsh6AAoJEBmVNT4SmAt+wVIQANPF9051t2hgxr1iIE5OWAl9 8zLRjumgIhvUZdmYERa/yUnoFANfoAGpMdnst5pkFlHYO9lWgTicNjfa9nGJ85uO IuFbZqeb4l2RI+5C9vlSuJTJiVStCDiJl+c25OJ4dkExNsGskqYiWSZ2XOkcku4e 1KGffT1cZRPYXFnkZJEPh8c8Ewa4gPFx2kBu6RMeCD3vKX4sW5SoCFmgG56UeqM6 NxqUU8zGD9hXYZi2q3wA7qDTflZ8ggR4MQG+Gh8CXUMMjJoZ6cztyj6sjvK20WtW G56VuNe/ZI+GE5yxCceo5DflMO5atxK9rUDRz4uZCcv+w5NtSZzeBRJVvdXiqhs3 CYUzoNNSdZYglTciRW5oleT5mULxtjC/tKJcZfgyFzT3jfeWlgWaap6rekOBtNCO ImRJ1YTI5bbIq6PjdSgtXd/2b165GsbmT8fPvbthzgwSo7wWnmwNRf0PsHw7VZDX nkZIFoIEYIHgi7AFH8wJN3zx8Mc06CFGf0p9xk/97wzqkMRML8K3dvSiwmt4Py69 NUF+NhF7OIqMibAr39yjAaUTrvWGUxfFafP8JEgw6Qtf3hwwRCS6bN2rR6c+1k63 ST8hkJfyWXMs4AsC+XGceGhFfGZez7Ac/HTc4QWrhsJNuf95pb7ocL1sSHsZcliV pigA3J5R564C3FfUTde3 =k4iY -----END PGP SIGNATURE----- --m1i1JxhQNEm7dh9MBpO8sdv62rRxP7VgF--