From owner-cvs-all@FreeBSD.ORG Tue May 6 06:48:18 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C952F37B401 for ; Tue, 6 May 2003 06:48:18 -0700 (PDT) Received: from heaven.gigo.com (heaven.gigo.com [64.57.102.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7178B43F93 for ; Tue, 6 May 2003 06:48:17 -0700 (PDT) (envelope-from lioux@brturbo.com) Received: from 200.193.225.71 (200-193-225-071.bsace7003.dsl.brasiltelecom.net.br [200.193.225.71]) by heaven.gigo.com (Postfix) with ESMTP id CA0F2B8C2 for ; Tue, 6 May 2003 06:48:16 -0700 (PDT) Received: (qmail 2394 invoked by uid 1001); 6 May 2003 13:34:58 -0000 Message-ID: <20030506133458.2393.qmail@exxodus.fedaykin.here> Date: Tue, 6 May 2003 10:34:36 -0300 From: Mario Sergio Fujikawa Ferreira To: Greg Lewis References: <200305060611.h466B2io078265@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200305060611.h466B2io078265@repoman.freebsd.org> X-Operating-System: FreeBSD 4.8-STABLE X-Disclaimer: I hope you find what you are looking for... in life :) User-Agent: Mutt/1.5.4i cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/java/jdk13/files patch-iomgr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 May 2003 13:48:19 -0000 On Mon, May 05, 2003 at 11:10:40PM -0700, Greg Lewis wrote: > glewis 2003/05/05 23:11:02 PDT > > FreeBSD ports repository > > Added files: > java/jdk13/files patch-iomgr.c > Log: > . Remove an assert() which asserts that if isatty() is true then > ttyname() must not return NULL. This isn't entirely true according > to the manual page (the device must be able to be found as well) and > certainly appears to not necessarily be true in the package building > environment on bento (plus at least the PR submitter's environment). > > Note that this assert() was, of course, only ever triggered when > running in debug mode (which most people don't, but does happen > during the build in some parts). Also note that there is a check > for isatty() preceding the call for ttyname() and a NULL return > from ttyname() is handled, so removing this assert should not > create any problems. Shouldn't we bump PORTREVISION? -- Mario S F Ferreira - DF - Brazil - "I guess this is a signature." FreeBSD Committer | CS Developer flames to beloved devnull@someotherworldbeloworabove.org feature, n: a documented bug | bug, n: an undocumented feature