From owner-svn-src-all@FreeBSD.ORG Thu Nov 27 02:55:35 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF4711065674 for ; Thu, 27 Nov 2008 02:55:35 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.185]) by mx1.freebsd.org (Postfix) with ESMTP id A861A8FC1A for ; Thu, 27 Nov 2008 02:55:35 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by rn-out-0910.google.com with SMTP id j71so725472rne.12 for ; Wed, 26 Nov 2008 18:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=ZhKFAxj23IyTBNUbpceIZ6zeECNCXedTOQV6jk5UMIY=; b=lEYdj6F7gUV0jL76RKjpD+g3mAGnd2RjU92UuKEosc5MLFbF6JDODpOrQiNevrmmy/ I3PtEmGCuQ4M+NOtNYHKGdH3Zvw92m9HXuks9bCE+sEPuacsbWtLidcjbKk5ChgWp/Vb bb3wks05nGPoKvA5PyWwKQSf5R8NGIZa9Wp58= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=x6o1H/2+jskXAlELuU9ZzSZ1tgQxJrJddsLyjjtjLcvMWrextTsGwaphLUIy0S1MuL C3/8n07BsHylvmGA78mDwAFq3GPQWbb7abW/jxXuTqMMYnMTS+7V/HzGHL0GCLDg7kyI j+kAhU6qUcNSLUinosnCwA7LvF9cA7/OH6t0s= Received: by 10.151.111.1 with SMTP id o1mr2328377ybm.224.1227753130288; Wed, 26 Nov 2008 18:32:10 -0800 (PST) Received: from kan.dnsalias.net (c-24-62-106-68.hsd1.ma.comcast.net [24.62.106.68]) by mx.google.com with ESMTPS id m56sm1150472rnd.1.2008.11.26.18.32.09 (version=SSLv3 cipher=RC4-MD5); Wed, 26 Nov 2008 18:32:09 -0800 (PST) Date: Wed, 26 Nov 2008 21:32:04 -0500 From: Alexander Kabaev To: Jack F Vogel Message-ID: <20081126213204.14db9a63@kan.dnsalias.net> In-Reply-To: <200811270219.mAR2Ji2M073024@svn.freebsd.org> References: <200811270219.mAR2Ji2M073024@svn.freebsd.org> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.11; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/xwJ66CLH=qBQHy._dxUvhsV"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r185356 - head/sys/dev/ixgbe X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2008 02:55:36 -0000 --Sig_/xwJ66CLH=qBQHy._dxUvhsV Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 27 Nov 2008 02:19:44 +0000 (UTC) Jack F Vogel wrote: > Author: jfv > Date: Thu Nov 27 02:19:44 2008 > New Revision: 185356 > URL: http://svn.freebsd.org/changeset/base/185356 >=20 > Log: > Small nit I just noticed, a pre-decrement should be post. >=20 > Modified: > head/sys/dev/ixgbe/ixgbe.c >=20 > Modified: head/sys/dev/ixgbe/ixgbe.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/ixgbe/ixgbe.c Thu Nov 27 02:18:43 2008 > (r185355) +++ head/sys/dev/ixgbe/ixgbe.c Thu Nov 27 02:19:44 > 2008 (r185356) @@ -3244,7 +3244,7 @@ fail: > * the rings that completed, the failing case will have > * cleaned up for itself. 'j' failed, so its the terminus. > */ > - for (int i =3D 0; i < j; ++i) { > + for (int i =3D 0; i < j; i++) { > rxr =3D &adapter->rx_rings[i]; > for (int n =3D 0; n < adapter->num_rx_desc; n++) { > struct ixgbe_rx_buf *rxbuf; Is C99 construct here intentional? If so, when did we agree on using only C99 compilers on our code base? =20 --=20 Alexander Kabaev --Sig_/xwJ66CLH=qBQHy._dxUvhsV Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFJLgakQ6z1jMm+XZYRAqekAJ9pUNa0z76G7JdZmiaOFZdtPpSougCeJ6cV kYDeSGSBJmyIqBOfv4EWwTo= =GEf0 -----END PGP SIGNATURE----- --Sig_/xwJ66CLH=qBQHy._dxUvhsV--