From owner-freebsd-fs@FreeBSD.ORG Fri Mar 25 16:53:19 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C3F11065672 for ; Fri, 25 Mar 2011 16:53:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 9110C8FC12 for ; Fri, 25 Mar 2011 16:53:18 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p2PGrEYr069328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 Mar 2011 18:53:14 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p2PGrEXW043050; Fri, 25 Mar 2011 18:53:14 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p2PGrEZh043049; Fri, 25 Mar 2011 18:53:14 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 25 Mar 2011 18:53:14 +0200 From: Kostik Belousov To: "Pedro F. Giffuni" Message-ID: <20110325165314.GO78089@deviant.kiev.zoral.com.ua> References: <201103251610.p2PGAFOb063448@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p2phRCRr7PirLLhx" Content-Disposition: inline In-Reply-To: <201103251610.p2PGAFOb063448@freefall.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2011 16:53:19 -0000 --p2phRCRr7PirLLhx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 25, 2011 at 04:10:15PM +0000, Pedro F. Giffuni wrote: > The following reply was made to PR kern/152079; it has been noted by GNAT= S. >=20 > From: "Pedro F. Giffuni" > To: bug-followup@FreeBSD.org > Cc: =20 > Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other= NetBSD/OpenBSD > Date: Fri, 25 Mar 2011 09:09:04 -0700 (PDT) >=20 > --0-691748129-1301069344=3D:71034 > Content-Type: text/plain; charset=3Dus-ascii > =20 > Include a small fix from NetBSD: > =20 > msdosfs_vnops.c Revision 1.73: > Remove a vnode reference leak from msdosfs_rename. Release tdvp if either > doscheckpath() or relookup() fails. > =20 > Adjust test fs/vfs/t_vnops.c and remove the link count test for msdos. > =20 > Fixes NetBSD PR #44661 Can you extract the test referenced in the commit message ? I think that s/EROFS/EINVAL/ change could and should be committed first, and then the (potential) fix for the vnode leakage as a separate commit. --p2phRCRr7PirLLhx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk2MyHoACgkQC3+MBN1Mb4gGQwCfSQKDH2YijpLy6YYC3o/ArYU/ 6ygAnjvoPU4c77LiJTYUx+3eKoWRNq1p =g0+4 -----END PGP SIGNATURE----- --p2phRCRr7PirLLhx--