Date: Mon, 27 Jan 2014 10:36:54 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r341341 - head/devel/xwpe Message-ID: <20140127103654.GA12714@FreeBSD.org> In-Reply-To: <20140127102231.GD30300@ithaqua.etoilebsd.net> References: <201401270841.s0R8fjq3007225@svn.freebsd.org> <20140127092855.GA88072@FreeBSD.org> <20140127102231.GD30300@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 27, 2014 at 11:22:31AM +0100, Baptiste Daroussin wrote:
> This particular port is a bit special as the DESTDIR variable is already
> defined it but for something totally different, thus I decided to inject a
> variable named STAGEDIR instead that is why I defined DESTDIRNAME to
> STAGEDIR in the makefile.
OK, fair enough. :) Thanks for replying back.
> Your remark is valid is still valid for ports doing
> --prefix=${STAGEDIR}${PREFIX} which is often wrong but not for those doing
> --prefix=\$${STAGEDIR}${PREFIX} :)
I've just checked StageDir wiki page again; it seems that it already
contains instructions on how to verify that STAGEDIR does not sneak inside
the binaries (via bzgrep vs. my own handcrafted strings-based approach).
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140127103654.GA12714>