From owner-dev-commits-src-all@freebsd.org Wed Aug 18 15:57:02 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B6DF3651BD4; Wed, 18 Aug 2021 15:57:02 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GqXb24Ygbz4f7S; Wed, 18 Aug 2021 15:57:02 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-il1-f175.google.com with SMTP id h29so2752012ila.2; Wed, 18 Aug 2021 08:57:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QWdq6Uxlyxyukoh36bOcJfRur6ZhWx6ZS/ahvcGG6eY=; b=DZt2+EH3DaqHPJvBXP997ZV0jy9nH5SFBqqJtWUg0HiZr2eaEyNcrhH3hUPsPbH9nE viXIbwGe4U8u+tJ3q2whH9uMLrUgJOZVxnwBzf59369hxJfxpUbxbRDIi+xIUBKwubJd HHJ53mDxHkalN5sJiPWcBHM40rZyv0aVVjA8+qe3RxEl6LKpQsNbUTUFivTQ/pVJ26mY pn+JMBkLq0ePzjjE1+ujzBsIIfbFdPzsfL+JLMAIqqE5SUkq5OpjhDNcJ76uuI2hCJsz ykWEaX9NQBld8KD4hKGLx0yrl75J2gm+gXKC86UNjbWjo/YGu94rf0tKDHimRRdVGH0h OsNw== X-Gm-Message-State: AOAM5315+AYNveHDRVk/PXtGm3rzo6Hc85toq6TiQSSWAuCVSlxmAhVd qDsvCaa5zwdJq4+7vvyBUiDmn1texXzQ5ZjL8TzLARnI X-Google-Smtp-Source: ABdhPJyZb91gnDUTl1yH8tu01SOj8nM7L5RMaeSdIoNAvkqJJdpkqae8nLAUEgtV0f5t3Qm9qg91/RzFHDCkZFuWVF0= X-Received: by 2002:a92:2e12:: with SMTP id v18mr6641035ile.100.1629302215660; Wed, 18 Aug 2021 08:56:55 -0700 (PDT) MIME-Version: 1.0 References: <202108180625.17I6PJmQ010784@gitrepo.freebsd.org> In-Reply-To: <202108180625.17I6PJmQ010784@gitrepo.freebsd.org> From: Ed Maste Date: Wed, 18 Aug 2021 11:56:35 -0400 Message-ID: Subject: Re: git: e3500c602b13 - main - ipmi: fix negative logic in watchdog control flag To: Wojciech Macek Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4GqXb24Ygbz4f7S X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2021 15:57:02 -0000 On Wed, 18 Aug 2021 at 02:25, Wojciech Macek wrote: > > The branch main has been updated by wma: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e3500c602b13f8252eb8bb779849c41d47306cee > > commit e3500c602b13f8252eb8bb779849c41d47306cee > Author: Wojciech Macek > AuthorDate: 2021-08-18 06:21:14 +0000 > Commit: Wojciech Macek > CommitDate: 2021-08-18 06:21:14 +0000 > > ipmi: fix negative logic in watchdog control flag Thanks! Avoiding negative logic is something that has been passed on as developer lore but isn't documented in a particularly obvious way. Yesterday I made a very small change to sysctl.9 to try to make the note about -ve logic stand out, but in the coming days I will try to take a more holistic look at style.9 to make guidance on sysctl naming and values more clear.