From owner-freebsd-current@FreeBSD.ORG  Sat Dec 22 18:56:49 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2A94216A41A
	for <freebsd-current@FreeBSD.ORG>; Sat, 22 Dec 2007 18:56:49 +0000 (UTC)
	(envelope-from xcllnt@mac.com)
Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.75])
	by mx1.freebsd.org (Postfix) with ESMTP id 26DEF13C459
	for <freebsd-current@FreeBSD.ORG>; Sat, 22 Dec 2007 18:56:49 +0000 (UTC)
	(envelope-from xcllnt@mac.com)
Received: from mac.com (asmtp008-s [10.150.69.71])
	by smtpoutm.mac.com (Xserve/smtpout012/MantshX 4.0) with ESMTP id
	lBMIum36022127; Sat, 22 Dec 2007 10:56:48 -0800 (PST)
Received: from [192.168.1.100] (209-128-86-226.bayarea.net [209.128.86.226])
	(authenticated bits=0)
	by mac.com (Xserve/asmtp008/MantshX 4.0) with ESMTP id lBMIul0k023810
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Sat, 22 Dec 2007 10:56:47 -0800 (PST)
Message-Id: <75E13C5B-F31A-4EA0-BE1E-2E909364064F@mac.com>
From: Marcel Moolenaar <xcllnt@mac.com>
To: "Wojciech A. Koszek" <wkoszek@FreeBSD.ORG>
In-Reply-To: <20071222040156.GA87017@FreeBSD.czest.pl>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v915)
Date: Sat, 22 Dec 2007 10:56:45 -0800
References: <20071222040156.GA87017@FreeBSD.czest.pl>
X-Mailer: Apple Mail (2.915)
Cc: freebsd-current@FreeBSD.ORG, emax@FreeBSD.ORG
Subject: Re: [RFC,
	PATCH] Getting rid of direct calls to keyboard's methods via
	kbdsw[] array
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Dec 2007 18:56:49 -0000


On Dec 21, 2007, at 8:01 PM, Wojciech A. Koszek wrote:

> My proposal is to unify a way in which we call such specialized
> methods, so that instead of direct array indexing used to call  
> specific
> keyboard method:
>
> 	(*kbdsw[(kbd)->kb_index]->enable)((kbd))
>
> We would use unified interface:
>
> 	kbdd_enable(kbd)
>
> Proposed patch is here:
>
> 	http://people.freebsd.org/~wkoszek/patches/tty/kbdcleanup.patch
>
> Suggestions are welcome.

I like it. It would be nice to be able to get rid of the 2nd 'd'
in the kbdd_ prefix though...

FYI,

-- 
Marcel Moolenaar
xcllnt@mac.com