From owner-svn-ports-head@freebsd.org Tue Oct 10 13:05:54 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21EA5E30EDA; Tue, 10 Oct 2017 13:05:54 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C08CB810A6; Tue, 10 Oct 2017 13:05:53 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id 1uEFejh0NDJTW1uEGeNXR8; Tue, 10 Oct 2017 07:05:49 -0600 X-Authority-Analysis: v=2.2 cv=B4DJ6KlM c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=02M-m0pO-4AA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=-pZLbuUkZStVDdMN4egA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id E0464A75; Tue, 10 Oct 2017 06:05:46 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v9AD5k9x056952; Tue, 10 Oct 2017 06:05:46 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201710101305.v9AD5k9x056952@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Alexey Dokuchaev cc: Cy Schubert , Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r451623 - in head/net/tcpview: . files In-Reply-To: Message from Alexey Dokuchaev of "Tue, 10 Oct 2017 07:30:11 -0000." <20171010073011.GA36833@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 10 Oct 2017 06:05:46 -0700 X-CMAE-Envelope: MS4wfBEp0dNmWHGYHJ93AIax709ln0ezVlmzggm5l+5UzeDs3eq+AWUAT1lyDJGSX19jX8zCP5qJsfohPuCr8fp4+HbXdDQp4rAdkRJIuyFTReq9XR6fCRaG dN4ZcEceXcj9mnTf+Wq7kEQEsR91XfX17bX9C4qJkbt8vmTmeTKI5z8VmzzZtTEKJiu8i4aUzNJd+fn3iy9B1P1CY6IhOTEeTqQj12wEKmQV+eCDqRwt7OlQ whMeoVftclzVx4A3CKfdLMgy2nn1a5iorBDen1wEhHCvn3QoAuHWyHX0bEG0etTUyVz89wGKQWy2rlP0vY1fKA== X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 13:05:54 -0000 In message <20171010073011.GA36833@FreeBSD.org>, Alexey Dokuchaev writes: > On Mon, Oct 09, 2017 at 10:34:03AM -0700, Cy Schubert wrote: > > In message <20171009170719.GA89682@FreeBSD.org>, Alexey Dokuchaev writes: > > > ... > > > > Added: head/net/tcpview/files/patch-hex.c > > > > @@ -0,0 +1,10 @@ > > > > +--- hex.c.orig 1993-04-22 13:40:04.000000000 -0700 > > > > ++++ hex.c 2017-10-06 07:25:01.182767000 -0700 > > > > +@@ -85,6 +85,7 @@ > > > > + char *s; > > > > + > > > > + do { > > > > ++#define gets(a) fgets(a,sizeof(a),stdin) > > > > + if( gets(str) == NULL ) > > > > > > gets(3) called only once in this port; why not simply patch that > > > single call properly instead of bringing in a "poor man's" macro? > > > > As an example. To open discussion of possibilities. > > I don't think that having this (even in some extra-guarded form) is > good *general* solution. Macros are fragile and things can go south > when the argument is more just a simple pointer. Which is the limitation of this. As I said, it was not perfict. > > I'm just as all of us want gets(3) to die out, but as long as we must > provide it in libc, putting __attribute__ ((__deprecated__)) of some > sort seems as a safer approach. Don't worry. gets() will be removed very shortly. See: - exp-run PR 222796 - patch D12298 https://reviews.freebsd.org/D12298 -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.