From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 9 03:35:34 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9642B16A4CE; Tue, 9 Mar 2004 03:35:34 -0800 (PST) Received: from sakura.ninth-nine.com (sakura.ninth-nine.com [219.127.74.120]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFE6943D1F; Tue, 9 Mar 2004 03:35:33 -0800 (PST) (envelope-from nork@FreeBSD.org) Received: from melfina.ninth-nine.com ([IPv6:2002:d312:f91e::1]) (authenticated bits=0) by sakura.ninth-nine.com (8.12.10/8.12.10/NinthNine) with ESMTP id i29BZTKJ070969 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 9 Mar 2004 20:35:32 +0900 (JST) (envelope-from nork@FreeBSD.org) Date: Tue, 9 Mar 2004 20:35:32 +0900 (JST) Message-Id: <200403091135.i29BZTKJ070969@sakura.ninth-nine.com> From: Norikatsu Shigemura To: peter@FreeBSD.org In-Reply-To: <200403091117.i29BHaKI070552@sakura.ninth-nine.com> References: <200403091117.i29BHaKI070552@sakura.ninth-nine.com> X-Mailer: Sylpheed version 0.9.9 (GTK+ 1.2.10; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: hackers@FreeBSD.org Subject: Re: add cvs -W option to disable -R/CVSREADONLYFS X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2004 11:35:34 -0000 Hi peter. On Tue, 9 Mar 2004 20:17:34 +0900 (JST) Norikatsu Shigemrua wrote: > >Synopsis: add cvs -W option to disable -R/CVSREADONLYFS > >Description: > I added a feature which is to nagate a effect of -R/CVSREADONLYFS > to cvs as -W option. Please review and commit. > >How-To-Repeat: > N/A > >Fix: > Following patches are for cvs-1.12.5. I wrote for FreeBSD's cvs. Please, please! - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Index: src/contrib/cvs/man/cvs.1 =================================================================== RCS file: /home/ncvs/src/contrib/cvs/man/cvs.1,v retrieving revision 1.20 diff -u -r1.20 cvs.1 --- src/contrib/cvs/man/cvs.1 13 Nov 2003 17:57:53 -0000 1.20 +++ src/contrib/cvs/man/cvs.1 9 Mar 2004 10:44:33 -0000 @@ -244,7 +244,8 @@ .SM CVSREADONLYFS environment variable is set. Using .B \-R -can also considerably speed up checkout's over NFS. +can also considerably speed up checkout's over NFS. If you want to disable +this feature, you should specify -W option. .TP .B \-v [ --version ] Displays version and copyright information for @@ -255,6 +256,10 @@ Overrides the setting of the .SM CVSREAD environment variable. +.TP +.B \-W +Turns off read-only repository mode. This is default mode, but it +typically uses to negate the effect of -R option. .TP .B \-g Forces group-write perms on working files. This option is typically Index: src/contrib/cvs/src/main.c =================================================================== RCS file: /home/ncvs/src/contrib/cvs/src/main.c,v retrieving revision 1.23 diff -u -r1.23 main.c --- src/contrib/cvs/src/main.c 7 Jul 2003 19:15:36 -0000 1.23 +++ src/contrib/cvs/src/main.c 9 Mar 2004 10:44:33 -0000 @@ -256,6 +256,7 @@ " -n Do not execute anything that will change the disk.\n", " -t Show trace of program execution -- try with -n.\n", " -R Assume repository is read-only, such as CDROM\n", + " -W Assume repository is writable (default).\n", " -v CVS version and copyright.\n", " -T tmpdir Use 'tmpdir' for temporary files.\n", " -e editor Use 'editor' for editing log information.\n", @@ -413,7 +414,7 @@ int help = 0; /* Has the user asked for help? This lets us support the `cvs -H cmd' convention to give help for cmd. */ - static const char short_options[] = "+QqgrwtnRlvb:T:e:d:Hfz:s:xaU"; + static const char short_options[] = "+QqgrwtnRWlvb:T:e:d:Hfz:s:xaU"; static struct option long_options[] = { {"help", 0, NULL, 'H'}, @@ -556,6 +557,10 @@ break; case 'R': readonlyfs = 1; + logoff = 1; + break; + case 'W': + readonlyfs = 0; logoff = 1; break; case 'n': - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -