From nobody Tue Aug 30 15:05:28 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MH9bZ4YlNz4Zgqg; Tue, 30 Aug 2022 15:05:30 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MH9bZ42qJz3vwh; Tue, 30 Aug 2022 15:05:30 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-qt1-x836.google.com with SMTP id j17so8703726qtp.12; Tue, 30 Aug 2022 08:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=Ce+MEALbOjirl697PD+zrq4sH82hx22Ilfkzi6NJkTQ=; b=amjWaxM+F7QyCU4CZ49fd34pXP8B1wI3k+kLR0TebxUmELHH0FzOP0Qb4Ru2WW0ujF mu5rRDfdrOF6FAOVy/fAFRkjFFEj4AtPIcgSe3ARDTi7nAuu05wuwYMb2MxEbnUyV6aR Atf4U+6X57eMCk0bKcW1NrFbL5bNhJCqkyQEIqtklYZDlx7wgxFP+odqzX5Jaz5SCrYD NSqLw+rBQRk77VZyob8BdXb6UKpTpktAsydvZJNmUPqAhVz36GqTeZ7vs07IgsoP5Ghf 5iLn4AgjXPsAon8qeRFBxjwAKHuEKgj27QcGMTVqlsbzQGykpoJX82v1GQ3WSXbr8JQs T57w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=Ce+MEALbOjirl697PD+zrq4sH82hx22Ilfkzi6NJkTQ=; b=xkfrx2EElyBXC+nJZQkpyp765VyHr2pqOSrn5kctMn/5kfL8ZJ3YFFK5wtd+iR2LpH o75tAfbl9Sw+hppa/f6wgwU0b7CMYw38y11W55+7ABBRkglTDT7VRdfqjwACxDEPY1Tw GLos6xnRwM//+1f4K09tavx6ph6+fzW51aa9sgj1vQv2js63KVH7lwEMtLTq6c1d5ILw G9I+/jNuaMa14xw2+XrDwV8VUjkPR6rJ+1rFBmYQPhvlRzV3hiWGLfkGur9qbxfokJMl M1m0OTRs377pHw1KjCoOOz0ObsIdnBloHc2pRT64n9s/n+tfq0rUWwT/5Gdc1rcxnYmt 7isw== X-Gm-Message-State: ACgBeo1bqEPMSF3lMk/djWh1Fm8T9sQR+W72OTQPL4rq29aK45E2helI /PRV2q3H/3UHMQKGA9tMxddYpeBEco4= X-Google-Smtp-Source: AA6agR4MeqPN2gsRBlU1gxqLxf5cWoBjbEP2LznP5mf3zNiVFHrsineTQTVV1OY9lwjJUDnxe68iLg== X-Received: by 2002:ac8:5f53:0:b0:343:a8d0:c81b with SMTP id y19-20020ac85f53000000b00343a8d0c81bmr14965645qta.489.1661871929875; Tue, 30 Aug 2022 08:05:29 -0700 (PDT) Received: from [10.231.1.66] (075-130-069-034.biz.spectrum.com. [75.130.69.34]) by smtp.gmail.com with ESMTPSA id c8-20020ac87d88000000b003435983a263sm7433160qtd.46.2022.08.30.08.05.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 08:05:29 -0700 (PDT) Message-ID: <837f27fc-97b0-6e71-50c0-12b8799e574d@FreeBSD.org> Date: Tue, 30 Aug 2022 11:05:28 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: git: 35b7759c05cb - main - cp: Fix build without VM_AND_BUFFER_CACHE_SYNCHRONIZED. Content-Language: en-US To: Rick Macklem , Mateusz Guzik Cc: "src-committers@FreeBSD.org" , "dev-commits-src-all@FreeBSD.org" , "dev-commits-src-main@FreeBSD.org" References: <202208301453.27UEroGr037461@gitrepo.freebsd.org> From: Alexander Motin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MH9bZ42qJz3vwh X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 30.08.2022 11:02, Rick Macklem wrote: > Mateusz Guzik wrote: >> On 8/30/22, Alexander Motin wrote: >>> The branch main has been updated by mav: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=35b7759c05cbc65c06d87141da79f0f80af0f458 >>> >>> commit 35b7759c05cbc65c06d87141da79f0f80af0f458 >>> Author: Alexander Motin >>> AuthorDate: 2022-08-30 14:51:21 +0000 >>> Commit: Alexander Motin >>> CommitDate: 2022-08-30 14:51:21 +0000 >>> >>> cp: Fix build without VM_AND_BUFFER_CACHE_SYNCHRONIZED. >>> >>> It allows to not use mmap() for small files, which is not helpful >>> in case of ZFS. Should be no functional change. >>> >> >> This should be of no use thanks to copy_file_range > cp does not use copy_file_range(2) for small files, if I recall correctly. Right. I tried to look for motivation, but history of this file goes back to 4.4 Lite. :) I wonder whether copy_file_range(2) for UFS does something clever, like this mmap() to avoid additional memory copy. For ZFS though it cause big problem with buffer cache squeezing ARC to absolute minimum. So if there is agreement to modernize this, I'd completely support it. -- Alexander Motin