From owner-cvs-all@FreeBSD.ORG Tue Jan 17 22:55:47 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 530AB16A422; Tue, 17 Jan 2006 22:55:47 +0000 (GMT) (envelope-from frank@exit.com) Received: from tinker.exit.com (tinker.exit.com [206.223.0.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 338A043D5A; Tue, 17 Jan 2006 22:55:45 +0000 (GMT) (envelope-from frank@exit.com) Received: from realtime.exit.com (realtime [206.223.0.5]) by tinker.exit.com (8.13.4/8.13.4) with ESMTP id k0HMti2V074553; Tue, 17 Jan 2006 14:55:44 -0800 (PST) (envelope-from frank@exit.com) Received: from realtime.exit.com (localhost [127.0.0.1]) by realtime.exit.com (8.13.4/8.13.4) with ESMTP id k0HMtgg2003678; Tue, 17 Jan 2006 14:55:42 -0800 (PST) (envelope-from frank@exit.com) Received: (from frank@localhost) by realtime.exit.com (8.13.4/8.13.4/Submit) id k0HMtff8003677; Tue, 17 Jan 2006 14:55:41 -0800 (PST) (envelope-from frank@exit.com) X-Authentication-Warning: realtime.exit.com: frank set sender to frank@exit.com using -f From: Frank Mayhar To: Alexander Leidinger In-Reply-To: <20060117225028.2f014c1e@Magellan.Leidinger.net> References: <200601171729.k0HHT3Ng026618@repoman.freebsd.org> <20060117225028.2f014c1e@Magellan.Leidinger.net> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Exit Consulting Date: Tue, 17 Jan 2006 14:55:40 -0800 Message-Id: <1137538540.2350.8.camel@realtime.exit.com> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 FreeBSD GNOME Team Port X-Virus-Scanned: ClamAV 0.87.1/1244/Tue Jan 17 00:46:07 2006 on tinker.exit.com X-Virus-Status: Clean Cc: cvs-src@freebsd.org, Alfred Perlstein , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/hpfs hpfs_vnops.c src/sys/fs/msdosfs msdosfs_denode.c src/sys/fs/ntfs ntfs_vnops.c src/sys/fs/nwfs nwfs_node.c src/sys/fs/smbfs smbfs_node.c src/sys/fs/udf udf_vnops.c src/sys/isofs/cd9660 cd9660_node.c src/sys/nfsclient ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: frank@exit.com List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2006 22:55:47 -0000 On Tue, 2006-01-17 at 22:50 +0100, Alexander Leidinger wrote: > On Tue, 17 Jan 2006 17:29:03 +0000 (UTC) > Alfred Perlstein wrote: > > to be identical, as if they were just clones of one original routine. > "Clones" as in identical and could be refactored into one function? As "refactored" is just a pretentious term for "rewritten," yes, pretty much. All of the xxx_reclaim() functions that I fixed were essentially identical. > Do you think this panic can be triggered by e.g. letting rhytmbox run > over a lot of music files on 2 msdosfs partitions to update the music > library? Yes, if it's dirtying pages on msdosfs (by, say, changing access times) and msdosfs has a putpages routine, _and_ that routine is called as a result of the destroy_object call. Otherwise no. -- Frank Mayhar frank@exit.com http://www.exit.com/ Exit Consulting http://www.gpsclock.com/ http://www.exit.com/blog/frank/