From owner-svn-src-head@freebsd.org Sat Sep 9 18:21:12 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05E89E00948 for ; Sat, 9 Sep 2017 18:21:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DCB1C727AD for ; Sat, 9 Sep 2017 18:21:11 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 878a9e27-958b-11e7-950d-03a3531dacf2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id 878a9e27-958b-11e7-950d-03a3531dacf2; Sat, 09 Sep 2017 18:20:17 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v89IK1Fh004297; Sat, 9 Sep 2017 12:20:01 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1504981201.32063.59.camel@freebsd.org> Subject: Re: svn commit: r323359 - in head/sys: conf dev/uart modules/uart From: Ian Lepore To: Sean Bruno , Marcin Wojtas , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 09 Sep 2017 12:20:01 -0600 In-Reply-To: References: <201709091142.v89BgX8e090592@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Sep 2017 18:21:12 -0000 On Sat, 2017-09-09 at 12:09 -0600, Sean Bruno wrote: > > On 09/09/17 05:42, Marcin Wojtas wrote: > > > > Author: mw > > Date: Sat Sep  9 11:42:32 2017 > > New Revision: 323359 > > URL: https://svnweb.freebsd.org/changeset/base/323359 > > > > Log: > >   Introduce UART driver module for Armada 3700 > >    > >   This patch adds support for UART in Armada 3700 family. > >   It exposes both low-level UART interface, as well as > >   standard driver methods. > >    > >   Submitted by: Patryk Duda > >   Obtained from: Semihalf > >   Sponsored by: Semihalf > >   Differential Revision: https://reviews.freebsd.org/D12250 > > > > Added: > >   head/sys/dev/uart/uart_dev_mvebu.c   (contents, props changed) > > Modified: > >   head/sys/conf/files > >   head/sys/modules/uart/Makefile > > Hrm ... I seem to be getting a compile failure after this: > > cc -target x86_64-unknown-freebsd12.0 --sysroot=/var/tmp/usr/src/tmp > -B/var/tmp/usr/src/tmp/usr/bin  -O2 -pipe  -fno-strict-aliasing > -Werror > -D_KERNEL -DKLD_MODULE -nostdinc   -DHAVE_KERNEL_OPTION_HEADERS > -include > /var/tmp/usr/src/sys/GENERIC-NODEBUG/opt_global.h -I. -I/usr/src/sys > -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer > -I/var/tmp/usr/src/sys/GENERIC-NODEBUG   -MD > -MF.depend.uart_dev_mvebu.o -MTuart_dev_mvebu.o -mcmodel=kernel > -mno-red-zone -mno-mmx -mno-sse -msoft-float > -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack- > protector > -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict- > prototypes > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ > -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas > -Wno-error-tautological-compare -Wno-error-empty-body > -Wno-error-parentheses-equality -Wno-error-unused-function > -Wno-error-pointer-sign -Wno-error-shift-negative-value > -Wno-error-address-of-packed-member  -mno-aes -mno-avx > -std=iso9899:1999 -c /usr/src/sys/dev/uart/uart_dev_mvebu.c -o > uart_dev_mvebu.o > In file included from /usr/src/sys/dev/uart/uart_dev_mvebu.c:39: > /usr/src/sys/dev/ofw/ofw_bus_subr.h:40:10: fatal error: > 'ofw_bus_if.h' > file not found > #include "ofw_bus_if.h" >          ^~~~~~~~~~~~~~ > 1 error generated. > *** Error code 1 > > Is there supposed to be processing of ofw_bus_if.m somewhere that is > currently missed? > > sean > ofw_bus_if.h needs to be added to SRCS= in the module makefile.  Over the years I learned to grep the c files for _if.h to figure out what generated files to add to a module makefile, but ofw_bus_if.h is insidious -- it gets included from ofw_bus_subr.h so nobody includes it directly and it always gets missed in new module makefiles. -- Ian