From owner-cvs-all Thu Mar 7 3:16: 1 2002 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 9575237B417; Thu, 7 Mar 2002 03:15:50 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g27BFnk51632; Thu, 7 Mar 2002 11:15:49 GMT (envelope-from mark@grimreaper.grondar.za) Received: from grimreaper (localhost [127.0.0.1]) by grimreaper.grondar.org (8.12.2/8.12.2) with ESMTP id g27BDlRV009179; Thu, 7 Mar 2002 11:13:48 GMT (envelope-from mark@grimreaper.grondar.za) Message-Id: <200203071113.g27BDlRV009179@grimreaper.grondar.org> To: obrien@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libcrypt crypt-md5.c crypt.c crypt.h misc.c src/secure/lib/libcrypt blowfish.c blowfish.h crypt-blowfish.c crypt-des.c References: <20020307025720.A63484@dragon.nuxi.com> In-Reply-To: <20020307025720.A63484@dragon.nuxi.com> ; from "David O'Brien" "Thu, 07 Mar 2002 02:57:20 PST." Date: Thu, 07 Mar 2002 11:13:46 +0000 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > As many people have asked in the past, please commit style(9) separately > from other commits. It is hard to see the WARNS/lint(1) changes from the > diff. In some cases that is Difficult(tm). > I would like to renew my opinion that WARNS/lint(1) fixes be reviewed on > -audit (or -hackers) before commit. (also might want to run them on your > local machine for a few days) You are changing a lot of code for reasons > of quieting lint(1), which a lot of us do not agree with. And lint(1) > quieting changes can easily become bugs as we saw with crypt-md5.c rev > 1.9. I've been running this locally since about October last year. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message