From nobody Thu Feb 5 14:45:47 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f6Klb3jtpz6QdSp for ; Thu, 05 Feb 2026 14:45:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f6Klb1bX5z3KSr for ; Thu, 05 Feb 2026 14:45:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770302747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Umwj2r/sH6BLhOpo748RfJ0Bj/5Z3zU0IsyPuySZbvg=; b=VrTzghPi5yzEPCVpSFuIDjpNrKxn8XbwBSY0L5fCO/+CFTWGd/K6ZCv8MhSxYaSCbdaXlE 4zyc2LRhUtU0n3AE3jcbxfYXARL5P5b8cqf69bRmdT7vLA4safgxpmRIfHRFg79O/RIlTt XDEC46AZNbmv+dAemblkySfRac11XlrjjhydT1zK5Ya3MkZLvH4WB+fUaiui4JVCgvpWDL PDETJ/vaZk9mUaIVUDD6+qusz6dHAhKuaz8Pw4A1xuCgtGrvgEX4I5in2S+TOmXy9MqSpx 86bydoAFMIlZKVWEI+/ZyOO0LXhVSnsF5HNk7zLUnNdGktQqWyXOu4TWP0lJhg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770302747; a=rsa-sha256; cv=none; b=cpunFiin1N0HVSBQU7szj9o67m1F3ZPtylS4C+gAoyUH1svMgvEeLc8yWmJ0UZfthlV2at yVAJjEndesPkqfOSiIdZzwX5hDGoLWy68CnN929effbUr8weqsidFTRMwDtD784xne1W1I KphAyGHxg2ff7/+BItYjZSAFyM8gAIdhyyJvuG5PzIkfvgcWmExJs7J22T5OrRzka9Tcts yHI1G3SD9Ca8Sh1oJhFQroGghDmHZufng6nWO9F6GbPShNjRsjBBqD9aKbVltaonP199vI blHieGF8JbXSWgfVXKeYz8S7/KlnkNOpU9YgxhNbeX+tGxPwCBjOXq5HVFDGRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770302747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Umwj2r/sH6BLhOpo748RfJ0Bj/5Z3zU0IsyPuySZbvg=; b=U+wlaiLOYVnJ/4yxi4KtcztIodKlriSPQcp9rH8REoDYsMgOVVfTGAByQgMT/sAJICKF9B IRKkgHaxWipf7CRSYpztICJfpsV+/SygvR4P5FD6DzM5exrTI6/KOjtdxCEaDWzA3okfiF RbyUa/QreNjpINBw3Yk4u/GU7UF1bMC/AjyG4awaYTu8yFV04c490O+a4QalXwvWB5xKD8 eRrQmj+ZQmMVkGUCNivRfmtIJYDjMcvkohU1t//4F97+g5vegS1515whw62+gYaS557nhJ lDClVZPAnQe8yJtDOWCl6EfnkE/zFR7mDImYZqtIwlIMHRWmbHi9V1t810T6zg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f6Klb1CQgzZtK for ; Thu, 05 Feb 2026 14:45:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c102 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Feb 2026 14:45:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 270492602b9b - main - diff: Add test case for pagination resource leak List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 270492602b9bd8b8fce4f021f055804978bf3f23 Auto-Submitted: auto-generated Date: Thu, 05 Feb 2026 14:45:47 +0000 Message-Id: <6984ad1b.3c102.4514c77b@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=270492602b9bd8b8fce4f021f055804978bf3f23 commit 270492602b9bd8b8fce4f021f055804978bf3f23 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-05 14:39:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-05 14:39:47 +0000 diff: Add test case for pagination resource leak The pagination code leaks either processes or descriptors or both, depending on the exact version of the code you have. Add a test case which exercises this leak to facilitate fixing it. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: thj, kevans Differential Revision: https://reviews.freebsd.org/D55111 --- usr.bin/diff/tests/diff_test.sh | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/usr.bin/diff/tests/diff_test.sh b/usr.bin/diff/tests/diff_test.sh index 89348d3a8b16..a3f76602cf37 100755 --- a/usr.bin/diff/tests/diff_test.sh +++ b/usr.bin/diff/tests/diff_test.sh @@ -411,6 +411,27 @@ bigu_body() diff -Astone -U$(((1<<31)-2)) a b } +prleak_head() +{ + atf_set "descr" "Verify that pagination does not leak resources" +} +prleak_body() +{ + local n=32 + mkdir a b + for hi in $(jot -w%02x $n 0) ; do + mkdir a/$hi b/$hi + for lo in $(jot -w%02x $n 0) ; do + echo "$hi$lo" >a/$hi/$lo + echo "$hi$lo" >b/$hi/$lo + done + done + ulimit -n 1000 + ulimit -u 1000 + atf_check diff -rul a b + atf_check diff -Astone -rul a b +} + atf_init_test_cases() { atf_add_test_case simple @@ -440,4 +461,5 @@ atf_init_test_cases() atf_add_test_case dirloop atf_add_test_case bigc atf_add_test_case bigu + atf_add_test_case prleak }