From owner-freebsd-bugs@FreeBSD.ORG  Wed Nov 28 06:45:15 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id AD34B198
 for <freebsd-bugs@FreeBSD.org>; Wed, 28 Nov 2012 06:45:15 +0000 (UTC)
 (envelope-from sustrik@250bpm.com)
Received: from mail.moloch.sk (chrocht.moloch.sk [62.176.169.44])
 by mx1.freebsd.org (Postfix) with ESMTP id 64F5B8FC08
 for <freebsd-bugs@FreeBSD.org>; Wed, 28 Nov 2012 06:45:15 +0000 (UTC)
Received: from [192.168.1.134] (188-167-109-79.dynamic.chello.sk
 [188.167.109.79])
 by mail.moloch.sk (Postfix) with ESMTPSA id 3D50D1801A9E;
 Wed, 28 Nov 2012 07:45:12 +0100 (CET)
Message-ID: <50B5B2F7.9050801@250bpm.com>
Date: Wed, 28 Nov 2012 07:45:11 +0100
From: Martin Sustrik <sustrik@250bpm.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
 rv:1.9.2.24) Gecko/20111109 Thunderbird/3.1.16
MIME-Version: 1.0
To: Bruce Evans <brde@optusnet.com.au>
Subject: Re: Possible non-conformance to POSIX
References: <50B53938.2010601@250bpm.com>
 <20121128092318.U1509@besplex.bde.org> <50B59F3D.5030102@250bpm.com>
In-Reply-To: <50B59F3D.5030102@250bpm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-bugs@FreeBSD.org
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2012 06:45:15 -0000

On 28/11/12 06:21, Martin Sustrik wrote:
> On 27/11/12 23:39, Bruce Evans wrote:
>
>>> #include <netinet/in.h>
>>> INADDR_ANY;
>>>
>>> The above results in 'u_int32_t undefined' error, which it shouldn't
>>> according to POSIX.
>>
>> <netinet/in.h> is careful to only declare uint32_t, but then it is
>> broken and uses u_int32_t for INADDR_ANY and INADDR_BROADCAST.
>> u_int32_t is also misused extensively in the definitions of INADDR_*
>> and IN_* under __BSD_VISIBLE. INADDR_ANY is broken even if __BSD_VISIBLE
>> is nonzero (the default), because the u_int32_t pollution is not
>> automatically supplied with __BSD_VISIBLE. It takes including
>> <sys/types.h> (with __BSD_VISIBLE) to get it.
>
> Yes. I figured out that including <sys/types.h> solves the problem. I
> was just pointing out the bug.
>
> If there's interest I can send a patch for INADDR_ANY and INADDR_BROADCAST.

I should also add that the problem is important because of feature 
checking in different build tools. The tool usually checks the existence 
of a symbol by trying to compile something like this:

#include <netinet/in.h>
INADDR_ANY;
int main () {return 0;}

If the compilation fails, it assumes the symbol is not defined. Which in 
not true in this context.

Btw, I've found another similar problem. Trying to compile the following:

#include <getifaddrs.h>
int main () {return 0;}

results in:
/usr/include/ifaddrs.h:34: error: expected specifier-qualifier-list 
before 'u_int'

Which, of course, means that the build tool (CMake in this case) reports 
that getifaddrs.h file is not available on FreeBSD platform.

Martin