Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 May 2020 23:53:46 +0000 (UTC)
From:      Rick Macklem <rmacklem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r360647 - projects/nfs-over-tls/sys/kern
Message-ID:  <202005042353.044NrkAY089428@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rmacklem
Date: Mon May  4 23:53:46 2020
New Revision: 360647
URL: https://svnweb.freebsd.org/changeset/base/360647

Log:
  Fix a leak in ktls_decrypt().
  
  ktls_decrypt() allocates an iov, but never free's it.
  This one line change fixes it.
  
  It might make more sense to make "iov" and "iov_cap" static instead,
  but I'll let jhb@ decide.

Modified:
  projects/nfs-over-tls/sys/kern/uipc_ktls.c

Modified: projects/nfs-over-tls/sys/kern/uipc_ktls.c
==============================================================================
--- projects/nfs-over-tls/sys/kern/uipc_ktls.c	Mon May  4 23:49:37 2020	(r360646)
+++ projects/nfs-over-tls/sys/kern/uipc_ktls.c	Mon May  4 23:53:46 2020	(r360647)
@@ -1865,6 +1865,7 @@ ktls_decrypt(struct socket *so)
 	sorwakeup_locked(so);
 
 deref:
+	free(iov, M_KTLS);
 	SOCKBUF_UNLOCK_ASSERT(sb);
 
 	CURVNET_SET(so->so_vnet);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005042353.044NrkAY089428>