Date: Tue, 8 Mar 2005 23:37:50 GMT From: Adam Weinberger <adamw@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/78607: Remove superfluous (and irritating) message Message-ID: <200503082337.j28NboD5084605@freefall.freebsd.org> Resent-Message-ID: <200503082340.j28Ne3L8084673@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 78607
>Category: ports
>Synopsis: Remove superfluous (and irritating) message
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 08 23:40:03 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Adam Weinberger
>Release: FreeBSD 4.11-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 4.11-STABLE FreeBSD 4.11-STABLE #16: Sat Feb 26 00:02:03 GMT 2005 kensmith@freefall.freebsd.org:/c/src/sys/compile/FREEFALL i386
>Description:
When one has DISABLE_VULNERABILITIES set, said administrator has
made a conscious decision to ignore the vulnerability database. Therefore,
having "===> Vulnerability check disabled" printed for each and
every build gets really annoying. The message reminding users that
the vulnerability database is disabled because it doesn't exist is
fine, because it is there to inform users who don't know about it. But
when you've chosen to disable vulnerability checks, having a reminder of
this for each and every build is irritating and silly.
As it stands right now, if you don't have the vulnerability database
installed, all DISABLE_VULNERABILITIES does for you is remove
", database not found" from a string.
I ask that the message please be removed. The attached patch does
just that.
And uh, while you're at it, could you please change the message two lines
above to "===> Vulnerability check disabled (database not found)"? That
comma makes it a run-on sentence.
>How-To-Repeat:
>Fix:
--- portmk_msg.patch begins here ---
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.510
diff -u -r1.510 bsd.port.mk
--- bsd.port.mk 28 Feb 2005 21:09:04 -0000 1.510
+++ bsd.port.mk 8 Mar 2005 23:24:46 -0000
@@ -3032,8 +3032,6 @@
else \
${ECHO_MSG} "===> Vulnerability check disabled, database not found"; \
fi
-.else
- @${ECHO_MSG} "===> Vulnerability check disabled"
.endif
# Fetch
--- portmk_msg.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503082337.j28NboD5084605>