From owner-svn-src-all@freebsd.org Sun Sep 1 19:32:40 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 91565E2D90; Sun, 1 Sep 2019 19:32:40 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M3Jm0zmxz3F0T; Sun, 1 Sep 2019 19:32:39 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 4VaViogUiSrVc4VaXi7IEi; Sun, 01 Sep 2019 13:32:37 -0600 X-Authority-Analysis: v=2.3 cv=L5ZjvNb8 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=J70Eh1EUuV4A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=TOZmh0hOhYF69Vy31y0A:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 0AD85500; Sun, 1 Sep 2019 12:32:35 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x81JWY0O004077; Sun, 1 Sep 2019 12:32:34 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x81JWYts004074; Sun, 1 Sep 2019 12:32:34 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201909011932.x81JWYts004074@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Ed Maste cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio In-reply-to: <201909011612.x81GC5DW097846@repo.freebsd.org> References: <201909011612.x81GC5DW097846@repo.freebsd.org> Comments: In-reply-to Ed Maste message dated "Sun, 01 Sep 2019 16:12:05 -0000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 01 Sep 2019 12:32:34 -0700 X-CMAE-Envelope: MS4wfMXqs23pQaEQcU0x4AUfkYc7tIKvTSQ04/3JU1OniiUVHt7M93RyrEuWFAxYnUNDAOsxi3lAhDstnabkX9QRA8E4JH4FtZmSWQuz+22hbvIEXxb1tVwQ lXfo+SVwFdyi3kPxgc+j6aFUAfFdBv1WO24ncApoq0j2UaF1LRlz3OXdrKhvuv6LF+LoDti4e0NnI3/GrsHVH2b5qtusxak1FRczJ/Zqn8ArturFXWzhIXLJ GfSwQ1/tXbl5SqzyD6wGE3YUb2T4OxrLoTgn2q1vrTenjGBBlYRKMpK8tUJUz2fM X-Rspamd-Queue-Id: 46M3Jm0zmxz3F0T X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.95)[-0.946,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 19:32:40 -0000 In message <201909011612.x81GC5DW097846@repo.freebsd.org>, Ed Maste writes: > Author: emaste > Date: Sun Sep 1 16:12:05 2019 > New Revision: 351659 > URL: https://svnweb.freebsd.org/changeset/base/351659 > > Log: > libc: remove gets > > gets is unsafe and shouldn't be used (for many years now). Leave it in > the existing symbol version so anything that previously linked aginst it > still runs, but do not allow new software to link against it. > > (The compatability/legacy implementation must not be static so that > the symbol and in particular the compat sym gets@FBSD_1.0 make it > into libc.) > > PR: 222796 (exp-run) > Reported by: Paul Vixie > Reviewed by: allanjude, cy, eadler, gnn, jhb, kib, ngie (some earlie > r) > Relnotes: Yes > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D12298 > > Modified: > head/contrib/libc++/include/cstdio > head/contrib/netbsd-tests/lib/libc/ssp/h_gets.c > head/gnu/lib/libssp/Makefile > head/include/stdio.h > head/lib/libc/stdio/fgets.3 > head/lib/libc/stdio/gets.c > head/lib/libc/stdio/stdio.3 Should we encourage the use of gets_s() in the man page or in other doc? This probably requires a __FreeBSD_version bump. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.