From owner-cvs-all@FreeBSD.ORG  Wed Jun 16 03:03:21 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B632B16A4CE; Wed, 16 Jun 2004 03:03:21 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 36E1743D49; Wed, 16 Jun 2004 03:03:21 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.11/8.12.11) with ESMTP id i5G3224l015388;
	Tue, 15 Jun 2004 21:02:02 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Tue, 15 Jun 2004 21:02:16 -0600 (MDT)
Message-Id: <20040615.210216.97064988.imp@bsdimp.com>
To: jhb@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200406152008.50656.jhb@FreeBSD.org>
References: <200406150212.i5F2CCaH095335@repoman.freebsd.org>
	<200406152008.50656.jhb@FreeBSD.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@freebsd.org
cc: njl@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/i386/i386 bios.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jun 2004 03:03:22 -0000

In message: <200406152008.50656.jhb@FreeBSD.org>
            John Baldwin <jhb@freebsd.org> writes:
: On Monday 14 June 2004 10:12 pm, Nate Lawson wrote:
: > njl         2004-06-15 02:12:12 UTC
: >
: >   FreeBSD src repository
: >
: >   Modified files:
: >     sys/i386/i386        bios.c
: >   Log:
: >   We only need the devclass_find() result, not the softc.
: 
: The devclass still exists if there is no acpi0 device due to 'set 
: hint.acpi.0.disabled=1'.  Perhaps devclass_get_device() is more appropriate 
: than devclass_get_softc() though.

The hint is insufficient to create the devclass, I believe.  It exists
because there's a node in the tree or could be a node in the tree.
devclass_get_device() and checking to see if it is attached might be
even better.

Warner