Date: Thu, 29 Oct 2015 14:32:14 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Eric van Gyzen <eric@vangyzen.net>, Tijl Coosemans <tijl@FreeBSD.org>, Jeff Roberson <jeff@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, kib@FreeBSD.org Subject: Re: svn commit: r289279 - in head/sys: kern vm Message-ID: <5632905E.6010202@FreeBSD.org> In-Reply-To: <56328224.2010706@vangyzen.net> References: <201510140210.t9E2A79H056595@repo.freebsd.org> <20151029212554.799f76eb@kalimero.tijl.coosemans.org> <56328224.2010706@vangyzen.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9N6WHGihGOUR0kSbCeT7g5oIkp0xq6khf Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/29/2015 1:31 PM, Eric van Gyzen wrote: > On 10/29/2015 15:25, Tijl Coosemans wrote: >> On Wed, 14 Oct 2015 02:10:07 +0000 (UTC) Jeff Roberson <jeff@FreeBSD.o= rg> wrote: >>> Author: jeff >>> Date: Wed Oct 14 02:10:07 2015 >>> New Revision: 289279 >>> URL: https://svnweb.freebsd.org/changeset/base/289279 >>> >>> Log: >>> Parallelize the buffer cache and rewrite getnewbuf(). This results= in a >>> 8x performance improvement in a micro benchmark on a 4 socket machi= ne. >>> =20 >>> - Get buffer headers from a per-cpu uma cache that sits in from of= the >>> free queue. >>> - Use a per-cpu quantum cache in vmem to eliminate contention for = kva. >>> - Use multiple clean queues according to buffer cache size to elim= inate >>> clean queue lock contention. >>> - Introduce a bufspace daemon that attempts to prevent getnewbuf()= callers >>> from blocking or doing direct recycling. >>> - Close some bufspace allocation races that could lead to endless >>> recycling. >>> - Further the transition to a more modern style of small functions= grouped >>> by prefix in order to improve growing complexity. >> >> I have an i386 system that locks up easily after this commit. Booting= >> into single user and running make installkernel triggers it consistent= ly. >=20 > I can't help you debug this, but I noticed a follow-up commit that fixe= d > an uninitialized pointer introduced by this commit: >=20 > https://svnweb.freebsd.org/changeset/base/290155 >=20 > Pending comments from more enlightened folk, you might try updating to > that rev (if you can do so without a lockup...). I didn't analyze it enough to know if my change was fixing an actual bug and in what case. I think if so it is more likely to have random panics then a consistent lock up though. --=20 Regards, Bryan Drewery --9N6WHGihGOUR0kSbCeT7g5oIkp0xq6khf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWMpBfAAoJEDXXcbtuRpfPwOkIAJa5ZkknxTGob6FpiUC1SEHc y4tZktwTBU3n1M3+0D86fIHiC/a0XAFW4QyxbBZ6f+orH2ZpXN9+IIL6HralBdu4 cfXktYezfUlRcGyRNMmQc6Yg6a5gqVTwE7esVoxF6GKd7IPkN15mDJkceGAAAqZ5 659fD3Ine9IpEyFaDtcOXfgVVJQHIJ5xDJayv04BRVe6srkTan0hx83Lc8vR/eV7 wq4b/Lxi1DwFC48THAsxJFO1rQy0Lg8T9D4k41VCQuCiQa2FMPXBfvUKZUGzCaun ySHdWNwtUV5tW3ufqnzRyFdWqb+3ODam6keeckvBRYAUZUOo1ide0sWagBvEq0w= =TOr/ -----END PGP SIGNATURE----- --9N6WHGihGOUR0kSbCeT7g5oIkp0xq6khf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5632905E.6010202>