From owner-freebsd-current@FreeBSD.ORG  Mon Feb 14 18:38:07 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0532F1065747;
	Mon, 14 Feb 2011 18:38:07 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id CE44C8FC1D;
	Mon, 14 Feb 2011 18:38:06 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 8B1EB46B03;
	Mon, 14 Feb 2011 13:38:06 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.10])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id AE46E8A009;
	Mon, 14 Feb 2011 13:38:05 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: "Jung-uk Kim" <jkim@freebsd.org>
Date: Mon, 14 Feb 2011 13:37:59 -0500
User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; )
References: <AANLkTi=C31iGJMonj7E3DGLWhx0cSKQR=b7ZHTv9CdmA@mail.gmail.com>
	<AANLkTimKJnyFQgTgtLTOFvmcY4fbK5gdT6mwt9zB=+RY@mail.gmail.com>
	<201102141330.20330.jkim@FreeBSD.org>
In-Reply-To: <201102141330.20330.jkim@FreeBSD.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201102141337.59203.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Mon, 14 Feb 2011 13:38:05 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=0.5 required=4.2 tests=BAYES_00,MAY_BE_FORGED,
	RDNS_DYNAMIC autolearn=no version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx
Cc: freebsd-current@freebsd.org, Matthew Fleming <mdf356@gmail.com>
Subject: Re: acpi_resource bug?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Feb 2011 18:38:07 -0000

On Monday, February 14, 2011 1:30:18 pm Jung-uk Kim wrote:
> On Monday 14 February 2011 10:29 am, Matthew Fleming wrote:
> > On Mon, Feb 14, 2011 at 6:24 AM, John Baldwin <jhb@freebsd.org> 
> wrote:
> > > On Sunday, February 13, 2011 2:46:07 pm Matthew Fleming wrote:
> > >> I'm not very familiar with the acpi code, but we have seen an
> > >> intermittent issue on boot:
> > >>
> > >> 1) should the length of the bcopy() be changed to either respect
> > >> res->Length or the actual length of the ACPI_RESOURCE_DATA for
> > >> the type?
> > >
> > > It should just use res->Length:
> >
> > Is there a guarantee that res->Length is <= sizeof(ACPI_RESOURCE) ?
> 
> No.  Please try the attached patch (after your r218685).

I think your patch is correct, but are you saying that ACPICA will return a 
resource with a size that doesn't match its type?

ACPI_RESOURCE_DATA is a union of all the various resource types, and it does 
contain both ACPI_RESOURCE_IRQ and ACPI_RESOURCE_EXTENDED_IRQ, so it's hard
to see how res->Length would be greater than the size of ACPI_RESOURCE.

-- 
John Baldwin