From owner-svn-src-all@freebsd.org Tue Aug 21 06:28:01 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5A241108AC53; Tue, 21 Aug 2018 06:28:01 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 06A6C75457; Tue, 21 Aug 2018 06:28:01 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (unknown [51.52.172.98]) by mail.baldwin.cx (Postfix) with ESMTPSA id 8572110AFD2; Tue, 21 Aug 2018 02:27:59 -0400 (EDT) Subject: Re: svn commit: r338128 - in head: cddl/lib/libzpool cddl/usr.bin/ztest cddl/usr.sbin/zdb sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys sys/conf sys/modules/zfs To: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201808210345.w7L3jADR035282@repo.freebsd.org> From: John Baldwin Message-ID: <31e29ae2-99ea-ab62-c337-c1d7f0b4aab5@FreeBSD.org> Date: Tue, 21 Aug 2018 07:27:58 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201808210345.w7L3jADR035282@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Tue, 21 Aug 2018 02:27:59 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 06:28:01 -0000 On 8/21/18 4:45 AM, Matt Macy wrote: > Author: mmacy > Date: Tue Aug 21 03:45:09 2018 > New Revision: 338128 > URL: https://svnweb.freebsd.org/changeset/base/338128 > > Log: > Make dnode definition uniform on !x86 > > gcc4 requires -fms-extensions to accept anonymous union members > > Modified: > head/cddl/lib/libzpool/Makefile > head/cddl/usr.bin/ztest/Makefile > head/cddl/usr.sbin/zdb/Makefile > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dnode.h > head/sys/conf/kern.pre.mk > head/sys/modules/zfs/Makefile Are you really sure you need the CFLAGS changes in all these places? Userland already defaults to a 'cstd' of 'gnu99' which allows anonymous unions by default (whereas the kernel uses 'c99'), and kern.pre.mk already adds -fms-extensions to CFLAGS earlier in the file (so that change is redundant). kmod.mk also adds -fms-extensions already (so the ZFS change should be redundant). As mentioned earlier, already uses anonymous unions, so nothing would compile unless this already worked. I suspect the real issue is that ZFS when compiled into the kernel uses a custom set of CFLAGS that might not be picking up the CFLAGS.gcc. In summary, all of the CFLAGS changes look wrong / redundant. Can you share what build error you were actually seeing without the CFLAGS changes? -- John Baldwin