From owner-freebsd-arm@FreeBSD.ORG  Tue May  3 20:42:06 2011
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C49A4106566C
	for <freebsd-arm@freebsd.org>; Tue,  3 May 2011 20:42:05 +0000 (UTC)
	(envelope-from damjan.marion@gmail.com)
Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com
	[209.85.215.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 198BA8FC19
	for <freebsd-arm@freebsd.org>; Tue,  3 May 2011 20:42:04 +0000 (UTC)
Received: by eyg7 with SMTP id 7so202682eyg.13
	for <freebsd-arm@freebsd.org>; Tue, 03 May 2011 13:42:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:from:content-type:content-transfer-encoding
	:subject:date:message-id:to:mime-version:x-mailer;
	bh=/mBbzQcmQywuOgO4W8RhU3n0iHWxX69XyuOsMqfDnBs=;
	b=o9C/3uyC2GIyepAfBpE7BWZpdAYnaFkv57FqimfThOEGTYyMmfIpFtSBu66IINo77z
	/gRrh1nfVwumukz+ZToc9XCq66Qfbvqo9b06v8kTTegB8Ey4Qg4hSmzjjKqEyflLWINS
	CMfeR1h25eMbIvHrWhJu1NcE9WGWiUlo8C9F0=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:content-type:content-transfer-encoding:subject:date:message-id
	:to:mime-version:x-mailer;
	b=dyOG/4Ws5D6fg77NiFJX3RpzPE/u6aUN9Rq1zt+Gm7L7d7ZmHhJCmvrEhLkModbC97
	n5ggURpMEsWvQd9If2tg4JPK+d+PnXwifkNvB1tDh/aEXn1vyHVLmpp1MNtD5AvUqs8e
	6c6MrfGzlsXhrKH1Yx3KzjBUQZ/fxssKNmQso=
Received: by 10.213.101.11 with SMTP id a11mr216074ebo.86.1304455323799;
	Tue, 03 May 2011 13:42:03 -0700 (PDT)
Received: from [192.168.123.4] (cpe-109-60-66-194.zg3.cable.xnet.hr
	[109.60.66.194])
	by mx.google.com with ESMTPS id c14sm311916eeb.25.2011.05.03.13.42.01
	(version=TLSv1/SSLv3 cipher=OTHER);
	Tue, 03 May 2011 13:42:02 -0700 (PDT)
From: Damjan Marion <damjan.marion@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Date: Tue, 3 May 2011 22:42:00 +0200
Message-Id: <B823839E-A0B2-4994-BDD8-6AC8747DCCEC@gmail.com>
To: freebsd-arm@freebsd.org,
 raj@semihalf.com
Mime-Version: 1.0 (Apple Message framework v1084)
X-Mailer: Apple Mail (2.1084)
Cc: 
Subject: Few issues with Marvell code
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 May 2011 20:42:06 -0000


Hi,

During my attempt to bring up 88F5181L I found few issues with current =
marvell code:

1. There is a typo in sys/arm/mv/common.c

-       { "mvrl,pcie", &decode_win_pcie_setup, NULL },
+       { "mrvl,pcie", &decode_win_pcie_setup, NULL },


2. Even if this is fixed, decode_win_pcie_setup will not be executed as =
in FDT file pci tree sits outside of SOC tree


3. CPU decode windows setup in FDT localbus tree is missing target, =
instead target is hardcoded to 1:

	cpu_win_tbl[t].target =3D 1;=20

On other side 1st column looks like a sequence. Is this 1st column =
needed?=20
Can we extend this definition to also have target defined?

I.e. In case of 88F5181L I need to add following window, and it will be =
more convenient to do that in FDT file.

	cpu_win_tbl[++t].target =3D 0x04;
	cpu_win_tbl[t].attr =3D 0x79;
	cpu_win_tbl[t].base =3D 0xf0000000;
	cpu_win_tbl[t].size =3D 0x01000000;
	cpu_win_tbl[t].remap =3D -1;


Thanks,

Damjan=